Add the Abats Keyboard Club Nayeon

[ramonimbao]

Description

Adds the Abats Keyboard Club Nayeon keyboard.

QMK Pull Request

qmk/qmk_firmware#16659

Checklist

• The VIA support for this keyboard is in QMK master already (MANDATORY)
• The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
• I have tested this keyboard definition using VIA's "Design" tab.
• I have tested this keyboard definition with firmware on a device.
• I have assigned alpha keys and modifier keys with the correct colors.
• The Vendor ID is not 0xFEED

[ramonimbao]

Hey @Xelus22, how would I go about with this? The conflicting keyboard is the Keygem KG60 (#1303) but checking the PR for it, it hasn't been merged to QMK yet (qmk/qmk_firmware#17565).

[Xelus22]

The automatic build says it is failing. So please fix any errors.

[ramonimbao]

The error is that the Keygem K60 conflicts with the Nayeon, but the Keygem K60 isn't merged yet with QMK despite being merged with VIA.

[wilba]

I did merge the Keygem boards into VIA before they were in QMK master.

That did not throw an error because the Nayeon VID/PID was not in VIA yet, so there was no conflict.

This is the first time we've had to deal with such a conflict, and it's a bit complicated.

@mrnoisytiger could have checked the VID/PID was unique (in QMK) before their PR to QMK and VIA

However, it is using ASCII codes "KG" for the VID (i.e. Keygem) and there's no obvious reason why "Abats Keyboard Club Nayeon" would be using "KG".

@ramonimbao @mrnoisytiger Can you give more information about this, and have a discussion here please?

I'd like a solution that is the least inconvenient to the people owning the PCBs, and least disruptive to both of you.

[ramonimbao]

The 4B47 is just very loosely based on Abats. I am alright with changing the VID/PID in QMK and then updating it here. I have some VIAL firmware prepared for the Nayeon since the boards use RP2040 and were made before the latest breaking change.

[Xelus22]

I guess you could just use ABA7?

[mrnoisytiger]

I chose 4B47 specifically because of a client request to use the KG hexcodes for KeyGem. Unfortunately we already have many boards produced with this firmware and they are already in market (with multiple variants too, basically copying all the DZ__ variants). I think like Xelus suggested to use ABA7 would be the least breaking and would probably align with Abats better?

[ramonimbao]

Alright, will go with ABA7. Thanks.

[ramonimbao]

Well that was quick. The new VID has been merged into QMK. Thanks everyone!

[wilba]

ggwp