Add VIA support for Keychron C1 Pro #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add VIA support for Keychron Q3
Add Keychron Q5
Add VIA JSONs for Keychron q8
Adapt the number of light effects to the current definition in qmk master.
Adapt the number of light effects to the current definition in qmk master.
Update the light effects definition to keep up with regular Q0(rev_0130) when PR(Add new board rev_0131 for Keychron Q0 #19547) is merge into qmk master.
Add VIA support for Keychron C1 Pro
Xelus22
requested changes
Jun 24, 2023
Update JSONs file of c1_pro
Deleteed ESC label
Xelus22
approved these changes
Jul 1, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added VIA JSONs for Keychron C1 Pro and request for a review, Thanks!
Description
QMK Pull Request
qmk/qmk_firmware#20700
Checklist
0xFEED