Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboards Dactyl lightcycle and maximus #1936

Merged
merged 4 commits into from
Aug 12, 2023
Merged

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Jul 6, 2023

Description

Add boards dactyl_lightcycle and dactyl_maximus

QMK Pull Request

Dactyl Lightcycle: qmk/qmk_firmware#20709
Dactyl Maximus: qmk/qmk_firmware#21338

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3/handwired/dactyl_lightcycle/dactyl_lightcycle.json Outdated Show resolved Hide resolved
v3/handwired/dactyl_lightcycle/dactyl_lightcycle.json Outdated Show resolved Hide resolved
changed pid to match source
@dunk2k dunk2k requested a review from Xelus22 July 8, 2023 08:32
@dunk2k
Copy link
Contributor Author

dunk2k commented Jul 8, 2023

Please colour code the keys.

  1. As these layouts are not conventional (i.e. do not have designate modifier, alpha, numpad, navigation positions), assigning a position as modifier/alpha would invalidate the layout's flexible and not conventional raison d'etre
  2. Other non-conventional layout keyboards do not have colour codes assigned. Examples:
    • crkbd/crkbd.json
    • handwired/dactyl_manuform/5x6_5/5x6_5.json
    • maplecomputing/jnao.json

@dunk2k
Copy link
Contributor Author

dunk2k commented Aug 12, 2023

Quick update: Both correction PRs have been merged in qmk/qmk_firmware

@Xelus22 Xelus22 merged commit 9ebc967 into the-via:master Aug 12, 2023
2 checks passed
@dunk2k
Copy link
Contributor Author

dunk2k commented Aug 12, 2023

@Xelus22 Thank you kindly

@dunk2k dunk2k deleted the dac_max branch November 30, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants