Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the split67 keyboard configuration #2035

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Create the split67 keyboard configuration #2035

merged 2 commits into from
Oct 7, 2023

Conversation

LXF-YZP
Copy link
Contributor

@LXF-YZP LXF-YZP commented Oct 1, 2023 •
edited by Xelus22
Loading

Description

Create the split67 keyboard configuration.

QMK Pull Request

qmk/qmk_firmware/pull/22107

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented Oct 1, 2023

image
this is NOT merged. tick the checklist again when it is.

@LXF-YZP
Copy link
Contributor Author

LXF-YZP commented Oct 1, 2023

image this is NOT merged. tick the checklist again when it is.

Sorry, my question, do we need to wait for the merger before we can have the next step?

@Xelus22
Copy link
Collaborator

Xelus22 commented Oct 2, 2023

Sorry, my question, do we need to wait for the merger before we can have the next step?

Yes QMK merge must go in first before VIA

@LXF-YZP
Copy link
Contributor Author

LXF-YZP commented Oct 2, 2023

Sorry, my question, do we need to wait for the merger before we can have the next step?

Yes QMK merge must go in first before VIA

ok,thanks.

@LXF-YZP
Copy link
Contributor Author

LXF-YZP commented Oct 4, 2023

Sorry, my question, do we need to wait for the merger before we can have the next step? 对不起，我的问题，我们需要等待合并才能进行下一步吗？

Yes QMK merge must go in first before VIA 是的，QMK 合并必须先进入，然后才能通过 VIA

Hello, qmk has been merged, please have time to review, thank you very much

@Xelus22 Xelus22 merged commit 76526cd into the-via:master Oct 7, 2023
2 checks passed
j4ckofalltrades pushed a commit to j4ckofalltrades/via-keyboards that referenced this pull request Oct 18, 2023
@pull @Xelus22
@mechlovin @moyi4681 @TreasureTypes @ziptyze @idank @studiokestra @duilchoi @peepeetee @casuanoob @nashrullahalifauzi @zvecr @coomstoolbox @LXF-YZP @edwardslau @yulei @hineybush
[pull] master from the-via:master (#79)
7b80c4a 
* [Core] Update the-via/reader dependency to 1.8.0 (the-via#2032)

* Update zed65-rev1.json (the-via#2024)

correct matrix position for "LAYOUTS/Bottom Row/Full Space 7U and Space 6.25U

* Update odinmini layout (the-via#2026)

* add dz60v2 keyboard (the-via#2027)

* Add VIA support for Treasure TYPE-9 Series III (the-via#2016)

Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com>

* update super16v3.json (the-via#2031)

* Add support for Span (the-via#2034)

* Update galatea-rev1.json

* Update galatea-rev2.json

* Add via support for Galatea rev3 (the-via#2033)

* Update galatea-rev3.json

* Update i160h.json

* Update i160s.json

* Update sinc-rev1a.json

* Update sinc-rev2a.json

* add linworks fave60a json (the-via#1855)

* add momokai aurora (the-via#2029)

* Bastard Keyboards: Add Dilemma Max and Charybdis Mini (the-via#2039)

* add linworks favepada json (the-via#1856)

* Add SyenaKeyboards (the-via#2037)

Co-authored-by: Syenasweta <syenasweta@gmail.com>

* Add VIA support for Drop CSTM80 (the-via#2041)

* Add handwired ziyoulang_k3_mod (the-via#2042)

* Create the split67 keyboard configuration (the-via#2035)

Co-authored-by: “yuezp” <“yuezpchn@126.com”>

* Add Graystudio Think6.5 V3 VIA support (the-via#2044)

* Update think65v3_via.json

* Nico update (the-via#2017)

* initial commit (the-via#2048)

---------

Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com>
Co-authored-by: mechlovin <57231893+mechlovin@users.noreply.github.com>
Co-authored-by: dztech <moyi4681@users.noreply.github.com>
Co-authored-by: TreasureTypes <73436366+TreasureTypes@users.noreply.github.com>
Co-authored-by: ziptyze <mwcordier@gmail.com>
Co-authored-by: Idan Kamara <i@idank.me>
Co-authored-by: studiokestra <74369928+studiokestra@users.noreply.github.com>
Co-authored-by: DUILCHOI <48977039+duilchoi@users.noreply.github.com>
Co-authored-by: peepeetee <43021794+peepeetee@users.noreply.github.com>
Co-authored-by: casuanoob <96005765+casuanoob@users.noreply.github.com>
Co-authored-by: Syenasweta a.k.a. Nashrullah Ali Fauzi <nshrllh.l.fz@gmail.com>
Co-authored-by: Syenasweta <syenasweta@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Coom <1655787+coomstoolbox@users.noreply.github.com>
Co-authored-by: yuezp <49514776+LXF-YZP@users.noreply.github.com>
Co-authored-by: “yuezp” <“yuezpchn@126.com”>
Co-authored-by: Yizhen Liu <62583086+edwardslau@users.noreply.github.com>
Co-authored-by: yulei <yuleiz@gmail.com>
Co-authored-by: Josh Hinnebusch <joshhinnebusch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LXF-YZP @Xelus22