Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Velvet Solder and Hotswap PCBs #2072

Merged
merged 13 commits into from
Nov 5, 2023
Merged

Add Velvet Solder and Hotswap PCBs #2072

merged 13 commits into from
Nov 5, 2023

Conversation

mrnoisytiger
Copy link
Contributor

Description

Add Velvet Solder and Hotswap PCBs

QMK Pull Request

qmk/qmk_firmware#22284

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove V2 (src/ folder) definitions. Everything else looks good

@mrnoisytiger
Copy link
Contributor Author

Remove V2 (src/ folder) definitions. Everything else looks good

It's been deleted! Thanks!

@Xelus22 Xelus22 merged commit 9f70a91 into the-via:master Nov 5, 2023
2 checks passed
@mrnoisytiger
Copy link
Contributor Author

Thanks Xelus!

@mrnoisytiger mrnoisytiger deleted the velvet branch November 5, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrnoisytiger @Xelus22