Tvb cosim #99
Tvb cosim #99
Conversation
|
should I be able to test this with the current version of NEST or I need the latest/master? |
|
This version is independent of Nest or other simulator. There are a proof of concept based on this interface and Nest. The proof of concept use MPI for the communication. In consequence, you need a wrapper over this interface for the MPI communication. |
TVB-2697: Fixed displaying PSE count message for guid ranges
…ce time tab to render properly
TVB-2682: Set a specific default conductionSpeed in order for the spa…
…r Local Connectivity Creator
TVB-2648 TVB-2652 Review
TVB-2676: Solved problem with display_name
…iling because he import of operations still relies on operation.xml and does not correctly handle ViewModel...h5 (it is treated as DT).
TVB-2684 Remove FlowService.get_available_datatypes method, after review of unit-tests where it was used
…n using .column_attrs.keys() and remove 'type'
…attributes and "id" for scientific metadata
…ivity Visualizer problem for simulations with surface.
TVB-2684 TVB-2679 Review FlowService, add ValueWrapper, unit-tests fixes
TVB-2689: add summary_info to DataType indexes
…werForm.get_filters TVB-2696 Make sure errors in filters are actually caught individually and the overlay appears
…oack configurations
…k_' string with "Linked "
… instead. Adjust forms and small refactor in SimulationController.
TVB-2703. Improve Simulation Configure - Persist - Launch flow
Test need to be improve with the system of test.
The buffer has some problems. I add a test for checking again this problems.
|
I update master and fix a bug in one of interface |
|
The public project of the co-simulation between Nest and TVB is as the following link : |
|
This PR is not easy to inspect (too many files appear changed). It would have been better to rebased towards master. |
NEED to add test for testing the model with more state variable and the model with varaible not part of coupling variable
| @@ -0,0 +1,83 @@ | |||
| # Copyright 2020 Forschungszentrum Jülich GmbH and Aix-Marseille Université | |||
| # "Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements; and to You under the Apache License, Version 2.0. " | |||
There was a problem hiding this comment.
Some files recently introduced differ in license from tvb-library GPL license.
While we have no problem with Apache license, and its compatibility, I am wondering if we could not keep consistency inside tvb-library and adhere to the same license, to be uniform (and from my perspective easier to present/package/distribute).
There was a problem hiding this comment.
I forget to change the licence.
|
|
||
| print("time_synchronize : %r s"%(time_synchronize*10**-3)) | ||
| print("max error S rate for 1 : %r" % max_error_s_1) | ||
| print("max error S rate for 2: %r" % max_error_s_2) |
There was a problem hiding this comment.
This is not really a unit-test, right?
Could you make it pytest conform ?
There was a problem hiding this comment.
Yes, it was some print for helping me to debug the code. I am modify all the test for be in the right format
|
|
||
| print("time_synchronize : %r s"%(time_synchronize*10**-3)) | ||
| print("max error S rate for 1 : %r" % max_error_s_1) | ||
| print("max error S rate for 2: %r" % max_error_s_2) |
There was a problem hiding this comment.
Also not a proper pyunitest.
print calls should not happen
|
|
||
| print("time_synchronize : %r s"%(time_synchronize*10**-3)) | ||
| print("max error S rate for 1 : %r" % max_error_s_1) | ||
| print("max error S rate for 2: %r" % max_error_s_2) |
There was a problem hiding this comment.
Maybe there are not really meant as unit-tests and should rather be examples, e.g. under tvb_documentation/demos ?
There was a problem hiding this comment.
Most of these test can be also use for demonstration.
We need to decide what is the most appropriate for the demonstration.
There was a problem hiding this comment.
I think both aspects should be covered.
under tests we should have automated checks, to be run with every change of the code, and ensure regressions don't happen (too often), while demo notebooks would also be great to have (under tvb_documentation would be my recommendation).
| s = result[0][1][:,0] | ||
| return time,s | ||
|
|
||
| class tvb_sim: |
There was a problem hiding this comment.
Could you pls adhere to the conventions: module (file names) should start with lowercase and class names be camel case ?
from tvb.simulator.interface_co_simulation_parallel import InterfaceCoSimulation
class TVBSim:
There was a problem hiding this comment.
Ok, I will refactore the code for the respect this convention
|
I close the Pull Request because I don't know how to fix my error due to the update of master. |
Add two monitors for interface with TVB :
The simplest is Interface_co_simulation_parallel.py. The input is the state variable and the output is the state of other node and the input of proxy node.
The second monitor is Interface_co_simulation.py. The input is intermediate result. This monitor is need some modification of the model in order to include this intermediate result.