implement AdvancedPrefsViewController with custom polling #97

JoniVR · 2019-05-18T12:31:41Z

partly implements changes discussed in #37.

This is what the menu currently looks like:

I'm thinking we'd probably want monitor specific polling settings though?
I'd like some input on how that should look, should we use another NSPopupMenu with the friendlyName?

TODO:

Translations? (can be done through new PR's)
Make it work for each display specific (this is a bit hard to test for me since I only have one display, and I wanted to hear the feedback first)
Add longerDelay option
Add hideOsd option

Please feel free to add/make changes or point out things that still need changing, this is very much a work in progress.

the0neyouseek · 2019-06-05T12:37:14Z

While we're at it, here are some things I'd also like to add to advanced prefs :

Inputs for the max/min value of brightness/volume for sliders and using keyboard (with default 0 and 100 or max value from ddc)
Input to change the modifiers for smaller increment (with default alt + shift)
Reset all prefs button

JoniVR · 2019-06-05T12:42:38Z

Sounds like a good idea! I'm currently pretty busy studying but after I finish (which should be somewhere next week) I can continue to work on it.

Quick question, in the advanced prefs for polling, should I use a tableview for displaying the monitors and their settings like we do in DisplayPrefsController or just the way I did it in the screencapture up top but add an extra NSPopup button for each monitor? I have the NSPopup almost implemented but it might be better to use a CollectionView instead?

the0neyouseek · 2019-06-05T12:57:22Z

Hi @JoniVR and good luck with your finals !

Let's try with an NSPopup for now as to not overload this view too much

JoniVR · 2019-06-13T06:49:59Z

Something else we could add here would be another NSPopup for trying out different replyDelays to make debugging easier for people experiencing issues.

- added `DisplayManager` to manage display list - replaced popup menu with tableview (just works better) - added more specific cells - added DisplayDelegate to notify of changes

TODO: find a way to refresh menu states after reset

JoniVR · 2019-07-02T20:17:22Z

Some notes:

I went with the tableview approach anyways because it's much cleaner to do in code, especially when trying to update data. It also looks better when there's no connected displays.
I've added the reset prefs button but we still need a way to refresh the menu states when the prefs are reset.
I've separated the logic for holding the displays array.
Since we're using it in several places, it seemed like a better idea to me to move it to a separate DisplayManager. I was thinking about doing this using a singleton but eventually went with a dependency-injection like approach (if that's what you can call it). I'm not sure if you'll agree with this approach or not but let me know.
Adding the specificPollingMode to the whitelist still seems pretty impossible with the current implementation, unless I'm missing something. I think we could just get rid of it once we have the advanced settings implemented tbh.

Conflicts: MonitorControl.xcodeproj/project.pbxproj MonitorControl/AppDelegate.swift MonitorControl/Display.swift MonitorControl/Info.plist MonitorControl/View Controllers/DisplayPrefsViewController.swift MonitorControlHelper/Info.plist

In some cases (for example when holding down the volume buttons) the sliders would be changed on the background thread instead of the main thread

TODO: fix pollingMode not resetting

- removed whitelist - added Longer Delay button to `AdvancedPrefsViewController` - refactored some stuff

JoniVR · 2019-07-09T20:50:34Z

I think we could start wrapping up this PR (translations and cleanup and such) and perhaps if it's ready, release it and then open an issue with other stuff we might want to add to the advanced prefs as to not make this PR too big and get the most important stuff out there for specific issue fixes. (#37, #105 for example)

using the DisplayDelegate was unreliable and only worked for one VC (obviously)

JoniVR · 2019-07-10T13:28:32Z

I'm thinking it might be a good idea to add a help button which links to a wiki page on this repo where some of these advanced settings could be explained:

@the0neyouseek, Would you be open to enabling the wiki so that I can add some stuff like Polling Count, Longer Delay and Hide OSD to it?

It would also be possible to do this with the Apple Help Book functionality but it might be better to have it on the repo?

JoniVR · 2019-08-15T19:26:16Z

Wiki page has been created:
https://github.com/the0neyouseek/MonitorControl/wiki/Advanced-Preferences

All we need now is testing/review and translations.. I'm not really sure if having so many translations is going to be a good idea long term though.. given that now we'd have to ask everyone to translate this.

I'm also still having build issues, I don't know if I'm the only one but I'm unable to solve them. Replacing the $(CURRENT_BUILD_NUMBER) with actual number inside of the Plist files seems to be a temp workaround for me..

the0neyouseek · 2019-08-20T21:43:36Z

Hi @JoniVR I'll review the PR this week-end 😉

the0neyouseek

I've made some comments if you can check them out, otherwise great PR 👍

MonitorControl/UI/Cells/LongerDelayCellView.swift

MonitorControl/View Controllers/AdvancedPrefsViewController.swift

MonitorControl/AppDelegate.swift

MonitorControl/Display.swift

the0neyouseek · 2019-08-27T15:12:52Z

Looks good to me 👍

stereonom · 2019-08-29T14:11:29Z

Is there a way to download the new version anywhere with this new feature in it?

JoniVR · 2019-09-15T10:12:23Z

@stereonom Version 1.7.0 has been released which includes this :)

implement AdvancedPrefsViewController with custom polling

2962ffa

JoniVR added the Type: Enhancement Issue is an app enhancement label May 18, 2019

JoniVR mentioned this pull request May 23, 2019

Does Not Work After Waking from Sleep #40

Closed

JoniVR added 3 commits June 29, 2019 09:29

add multiple displays

89a6c6a

refactor

5708929

- added `DisplayManager` to manage display list - replaced popup menu with tableview (just works better) - added more specific cells - added DisplayDelegate to notify of changes

add resetAllPrefs button to AdvancedPrefsController

0399ee8

TODO: find a way to refresh menu states after reset

JoniVR added 9 commits July 2, 2019 23:12

Merge branch 'master'

63a9a55

Conflicts: MonitorControl.xcodeproj/project.pbxproj MonitorControl/AppDelegate.swift MonitorControl/Display.swift MonitorControl/Info.plist MonitorControl/View Controllers/DisplayPrefsViewController.swift MonitorControlHelper/Info.plist

fixes after merge

11fabb1

increase build number to fix build (heh)

90fba58

cleanup

2d9d5de

add missing value isEnabled when loading displays

78a8933

make sure slider values are being changed on main thread

00738c1

In some cases (for example when holding down the volume buttons) the sliders would be changed on the background thread instead of the main thread

cleanup

16778d8

update menu states when resetting preferences

8e5317b

TODO: fix pollingMode not resetting

cleanup

4eaa5a1

JoniVR mentioned this pull request Jul 9, 2019

freezed my hackitosh right from the start. Restart required to get back. #105

Closed

JoniVR added 3 commits July 9, 2019 20:57

replace whitelist with advanced settings options, refactor

44c7cc8

- removed whitelist - added Longer Delay button to `AdvancedPrefsViewController` - refactored some stuff

make sure startAtLogin value updates at right moment

6b25562

add hideOsd option to AdvancedPrefsViewController

3d245ce

JoniVR added 3 commits July 9, 2019 23:28

remove debugging safety

a950b2c

replace DisplayDelegate with Notification

106e1dc

using the DisplayDelegate was unreliable and only worked for one VC (obviously)

change longerDelay alert style to .critical

54831c0

disable cyclomatic_complexity warnings for switch statements

f743b25

add help button with link to wiki

842a626

JoniVR marked this pull request as ready for review August 15, 2019 19:25

JoniVR mentioned this pull request Aug 19, 2019

Display settings resets after sleep #17

Closed

JoniVR assigned reitermarkus and the0neyouseek and unassigned reitermarkus and the0neyouseek Aug 19, 2019

JoniVR requested review from reitermarkus and the0neyouseek August 19, 2019 18:37

the0neyouseek approved these changes Aug 27, 2019

View reviewed changes

the0neyouseek added the Priority: Major Issue is major (e.g. A lot of things broken…) label Aug 27, 2019

add suggested changes

6a567f4

JoniVR removed the request for review from reitermarkus August 27, 2019 13:06

JoniVR merged commit dd3d026 into master Aug 28, 2019

JoniVR deleted the advanced-settings branch August 28, 2019 10:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement AdvancedPrefsViewController with custom polling #97

implement AdvancedPrefsViewController with custom polling #97

JoniVR commented May 18, 2019 •

edited

Loading

the0neyouseek commented Jun 5, 2019 •

edited by JoniVR

Loading

JoniVR commented Jun 5, 2019

the0neyouseek commented Jun 5, 2019

JoniVR commented Jun 13, 2019

JoniVR commented Jul 2, 2019 •

edited

Loading

JoniVR commented Jul 9, 2019

JoniVR commented Jul 10, 2019 •

edited

Loading

JoniVR commented Aug 15, 2019 •

edited

Loading

the0neyouseek commented Aug 20, 2019

the0neyouseek left a comment

the0neyouseek commented Aug 27, 2019

stereonom commented Aug 29, 2019

JoniVR commented Sep 15, 2019

implement AdvancedPrefsViewController with custom polling #97

implement AdvancedPrefsViewController with custom polling #97

Conversation

JoniVR commented May 18, 2019 • edited Loading

TODO:

the0neyouseek commented Jun 5, 2019 • edited by JoniVR Loading

JoniVR commented Jun 5, 2019

the0neyouseek commented Jun 5, 2019

JoniVR commented Jun 13, 2019

JoniVR commented Jul 2, 2019 • edited Loading

JoniVR commented Jul 9, 2019

JoniVR commented Jul 10, 2019 • edited Loading

JoniVR commented Aug 15, 2019 • edited Loading

the0neyouseek commented Aug 20, 2019

the0neyouseek left a comment

Choose a reason for hiding this comment

the0neyouseek commented Aug 27, 2019

stereonom commented Aug 29, 2019

JoniVR commented Sep 15, 2019

JoniVR commented May 18, 2019 •

edited

Loading

the0neyouseek commented Jun 5, 2019 •

edited by JoniVR

Loading

JoniVR commented Jul 2, 2019 •

edited

Loading

JoniVR commented Jul 10, 2019 •

edited

Loading

JoniVR commented Aug 15, 2019 •

edited

Loading