Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

夜间模式适配补充 #1267

Merged
merged 23 commits into from
Dec 6, 2020
Merged

夜间模式适配补充 #1267

merged 23 commits into from
Dec 6, 2020

Conversation

LonelySteve
Copy link
Contributor

@LonelySteve LonelySteve commented Dec 3, 2020 •
edited

为了方便，干脆就在 commit message 写中文描述了，pr 里就放一些比较重要，需要配图的

@LonelySteve
fix(remove-promotions.css): update
a89593f
@LonelySteve
fix(dark style): video note
e221888 
re the1812#1143, the1812#1143 (comment)
@LonelySteve
fix(dark style): 专栏页的取关模态框
95c9315
@LonelySteve
fix(dark style): 创作团队的关注按钮（含宽屏模式）
b575a2b 
re the1812#1143, the1812#1143 (comment)
@LonelySteve
fix(dark style): 大会员的空间下昵称非粉色
9c94d26 
re the1812#1143, the1812#1143 (comment)
@LonelySteve
fix(dark style): 相簿收藏夹，课程收藏夹，课程 Tab
b4b17f0 
re the1812#1143

the1812#1143 (comment)
the1812#1143 (comment)
@LonelySteve
fix(dark style): 视频关注引导卡片
d97e42e 
re the1812#1143, the1812#1143 (comment)
@LonelySteve
fix(dark style): 投票选项最大项未跟随主题色
5a3e0a6 
re the1812#1143, the1812#1143 (comment)
@LonelySteve
fix(dark style): 动态卡片的动态，鼠标悬停装扮卡片文字时未跟随主题色
0affaa2 
re the1812#1143, the1812#1143 (comment)
@LonelySteve
fix(dark style): 投票下方的复选框勾选时应用了错误的滤镜
fe1be89 
re the1812#1143, the1812#1143 (comment)
@LonelySteve
fix(dark style): 原版顶栏专栏展开提示文本未跟随主题色
59e3cba
@LonelySteve LonelySteve marked this pull request as ready for review December 4, 2020 04:45
@Geeyun-JY3
Copy link

Geeyun-JY3 commented Dec 4, 2020 •
edited

既然做原版顶栏的适配要不把这几处也顺便做了呗(◔◡◔)🌚：

  • 夜间模式未完全适配集中反馈 #1143 (comment) 的最后一个：这里我其实比较建议按照白天的效果做，或者可以将白天效果和动态卡片的视频 tab 现在的夜间模式效果结合起来，即鼠标飘过视频／文章／直播时标题变为主题色的暗示，同时对应视频／文章／直播小卡片会有一层颜色相对更浅的蒙版，即现在原版顶栏的收藏和历史的效果。目前视频 tab 只有标题变为主题色，文章和直播是两者都没有；
  • 开通大会员 按钮跟随主题色 ，以更鲜艳的颜色提高用户充钱欲望（叔叔快给我打钱）
    image
    原版效果：
    image
  • 又一个刚发现的 bug：历史中的番剧影视标题不可见
    image
  • 用户信息卡片相关
    • 小 bug：
      • 用户名看不到（其实没打码，因为打码的时候根本就看不到）、等级提示
        image
      • 退出也看不到
        popup
      • 下方的关注、粉丝、动态鼠标悬停时跟随主题色
        image
        原版效果：
        image
    • 这三个图标需不需要跟随主题色呢
      image

@LonelySteve
fix(dark style): 改进原版顶栏的动态项目的悬浮状态样式
e484e43 
re the1812#1267, the1812#1267 (comment)
@LonelySteve
fix(dark style): 原版顶栏历史中番剧影视的标题颜色
e1b596e 
re the1812#1267, the1812#1267 (comment)
@LonelySteve
fix(dark style): 原版顶栏用户信息卡片的等级提示框
566d43b 
re the1812#1267, the1812#1267 (comment)
@LonelySteve
fix(dark style): 原版顶栏的退出按钮
0e7e9f1 
re the1812#1267, the1812#1267 (comment)
@LonelySteve
fix(dark style): 原版顶栏用户信息卡片的关注、粉丝、动态鼠标悬停时未跟随主题色
b797bb4 
re the1812#1267, the1812#1267 (comment)
@LonelySteve
fix(dark style): 原版顶栏的用户信息卡片的图标未跟随主题色
9a07132 
re the1812#1267, the1812#1267 (comment)
@LonelySteve
fix(dark style): 原版顶栏用户信息卡片的昵称（非大会员）
1eaa83c 
re the1812#1267, the1812#1267 (comment)
@LonelySteve
Copy link
Contributor Author

@Geeyun-JY3 嗯，陈叔叔没有给我打钱，除了那个大会员开通的按钮，其它的都做了

@Geeyun-JY3
Copy link

除了那个大会员开通的按钮，其它的都做了

你这样陈叔叔啊是真的生气了呢

@Geeyun-JY3 Geeyun-JY3 mentioned this pull request Dec 4, 2020
Closed
@LonelySteve LonelySteve marked this pull request as draft December 5, 2020 02:11
@LonelySteve LonelySteve marked this pull request as ready for review December 5, 2020 02:53
@the1812 the1812 merged commit c4bd8b4 into the1812:preview Dec 6, 2020
the1812 added a commit that referenced this pull request Dec 6, 2020
@the1812
Build PR #1267
dc1f789
@Geeyun-JY3
Copy link

Geeyun-JY3 commented Dec 6, 2020 •
edited

@Geeyun-JY3
Copy link

Geeyun-JY3 commented Dec 6, 2020 •
edited

@Geeyun-JY3
Copy link

Geeyun-JY3 commented Dec 6, 2020 •
edited

  • 音乐 PLUS 页面下方目前所在页码建议跟随主题色
    image
    image

@Geeyun-JY3
Copy link

如果顺便的话建议投票选项最大项条的外框也跟随主题色（跟随白天效果）

（不过很值得吐槽的是，在客户端这个外框确实没有跟随主题色，b 站前端客户端真是乱成一锅粥，各自乱，混在一起更乱）

LonelySteve added a commit to LonelySteve/Bilibili-Evolved that referenced this pull request Dec 7, 2020
@LonelySteve
fix(dark style): 相簿收藏夹的按钮文本颜色
7b18e70 
re the1812#1267, the1812#1267 (comment)
LonelySteve added a commit to LonelySteve/Bilibili-Evolved that referenced this pull request Dec 7, 2020
@LonelySteve
fix(dark style): 音乐 PLUS 页面的当前页码未跟随主题色
c75ca3d 
re the1812#1267, the1812#1267 (comment)
LonelySteve added a commit to LonelySteve/Bilibili-Evolved that referenced this pull request Dec 7, 2020
@LonelySteve
fix(dark style): 视频引导关注卡片的一键三连动画未跟随主题色
fc4d73a 
re the1812#1267, the1812#1267 (comment)
the1812 added a commit that referenced this pull request Dec 11, 2020
@the1812
Merge pull request #1281 from LonelySteve/preview
9c5d9d2 
#1267 补充
@Geeyun-JY3 Geeyun-JY3 mentioned this pull request Jul 26, 2021
Open
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the1812 the1812 the1812 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LonelySteve @Geeyun-JY3 @the1812