Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat#1291 && Fix#1768 #1767

Merged
merged 3 commits into from Apr 24, 2021
Merged

Feat#1291 && Fix#1768 #1767

merged 3 commits into from Apr 24, 2021

Conversation

FoundTheWOUT
Copy link
Contributor

在某一次编译中,编译器抽风了,没做gif。(能写个编译清理之类的task吗

附言:
前阵子逛知乎,偶然发现我们居然回复过同一个问题。。。就是vscode图标那个,大千世界...唯有缘妙不可言

@FoundTheWOUT FoundTheWOUT changed the title Feat#1291 Feat#1291 && Fix#1768 Apr 23, 2021
@the1812
Copy link
Owner

the1812 commented Apr 23, 2021

能写个编译清理之类的task吗

直接删掉项目根目录的 dev.cache

前阵子逛知乎,偶然发现我们居然回复过同一个问题。。。

这么神奇的吗2333

@the1812 the1812 changed the base branch from master to preview April 24, 2021 09:36
@the1812 the1812 merged commit 4f8fba6 into the1812:preview Apr 24, 2021
@FoundTheWOUT FoundTheWOUT deleted the feat#1291 branch April 24, 2021 09:40
the1812 added a commit that referenced this pull request Apr 25, 2021
@jiacchen
Copy link

感谢处理 #1768

我测试了一下新的1.12.6,发现开启深色模式已经正常了,但是到了白天关闭深色模式的时候原问题还存在。

@FoundTheWOUT
Copy link
Contributor Author

我测试了一下新的1.12.6,发现开启深色模式已经正常了,但是到了白天关闭深色模式的时候原问题还存在。

我刚刚测试了一下,在关闭B站的情况下,手动切换系统主题后再进入B站,无论是黑->白还是白->黑都是能正常转换的,但是系统自动的没试过。
你可以尝试一下自己手动改主题的话,是否能正常触发转换吗。
(这和系统有关系吗,你是用什么系统,虽然我在Win和Mac都测试了,都是能正确工作的

@jiacchen
Copy link

我测试了一下新的1.12.6,发现开启深色模式已经正常了,但是到了白天关闭深色模式的时候原问题还存在。

我刚刚测试了一下,在关闭B站的情况下,手动切换系统主题后再进入B站,无论是黑->白还是白->黑都是能正常转换的,但是系统自动的没试过。
你可以尝试一下自己手动改主题的话,是否能正常触发转换吗。
(这和系统有关系吗,你是用什么系统,虽然我在Win和Mac都测试了,都是能正确工作的

我用的是macOS,之前也是手动切换系统主题测试的,刚才又试了几次黑->白还是需要手动刷新,不太清楚什么原因😂

@the1812
Copy link
Owner

the1812 commented Apr 26, 2021

我之后加点 log 再看看吧

@jiacchen
Copy link

我之后加点 log 再看看吧

我刚才手动build了你们之前的两次commit,发现都正常工作,然后又试了一下1.12.6预览版,昨天黑->白时候的bug也没重现……不知道是什么玄学情况

我的issue应该可以close了,感谢两位(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants