Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extend-speed): 修复启用扩展倍速后,倍速列表不显示的问题 #3400

Merged
merged 2 commits into from
Jun 11, 2022

Conversation

LonelySteve
Copy link
Contributor

不确定这么改能不能兼容 3.x 新版播放器,有待测试

@imshixin
Copy link
Contributor

imshixin commented Jun 4, 2022

我发现Bwp-video下player-agent工作不正常,query.video.element没有变化,我之前在3.X时并没有碰到bwp的情况,所以没有发现这个问题

另外,我的播放器也变成了2.78.5😐,测不了了

@imshixin
Copy link
Contributor

imshixin commented Jun 4, 2022

这样应该也可以,而且改动更小

          style: maxMenuHeight => `
                  ${PLAYER_AGENT.custom.speedMenuList.selector} {
                    display: flex !important; /* 防止3.X样式覆盖 */
                    flex-direction: column;
                    justify-content: center; /* 添加倍速那一项,当鼠标在上半部分会有莫名其妙的'mouseleave', 用这个修复 */
                    overflow-y: auto;
                    max-height: ${maxMenuHeight}px;
                    visibility: hidden;
                  }
                  /* 修复2.X倍速列表显示问题 */
                  :is(${PLAYER_AGENT.custom.show.selector}) :is(${PLAYER_AGENT.custom.speedMenuList.selector}){
                    visibility: visible;
                  }
                  ${PLAYER_AGENT.custom.speedMenuList.selector}[style*="block"] {
                    visibility: visible;
                  }
                  `,
        }),

@LonelySteve LonelySteve marked this pull request as ready for review June 5, 2022 10:46
@the1812 the1812 merged commit fe04b5c into the1812:preview-fixes Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants