This repository has been archived by the owner on Dec 6, 2018. It is now read-only.
>#208 stm32: UART listen mode #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes listen mode tests, improved error handling in USART bus and corrected strings in the suite generator.
| return; | ||
| } | ||
| // TODO: implement | ||
| ecl_assert_msg(0, "Not implemeted!"); |
There was a problem hiding this comment.
How about using static_assert here?
There was a problem hiding this comment.
Static assert will hit, even if there is no function call immediately after template instance is created.
There was a problem hiding this comment.
Even worse - it will be there even if template is not touched
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes listen mode tests, improved error handling in USART bus and
corrected strings in the suite generator.