Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile page stats settings general cleanup #2601

Closed
2 tasks
DaneEvans opened this issue Feb 14, 2017 · 3 comments
Closed
2 tasks

Profile page stats settings general cleanup #2601

DaneEvans opened this issue Feb 14, 2017 · 3 comments
Assignees
Labels
1: MUST BE RESOLVED FOR RELEASE 5: Enhancement Build up on existing function that adds or improve functionality significantly

Comments

@DaneEvans
Copy link

DaneEvans commented Feb 14, 2017

Noticed on the Profile Filter settings page, but is likely elsewhere as well
This is due to the resizing of the page, but as you can see the checkbox, and the words of different elements can be split and occur on separate lines, these should be treated as one entity if possible

  • Ice climbing" is split between words
  • Aid solo" is split between the checkbox and Aid, which is even more confusing

While we're at it, could we add double spacing to make it easier to distinguish that it's the checkbox before that belongs to the text?

screenshot 2017-02-15 08 53 33

@brendanheywood
Copy link
Member

This will open a small can of worms but thats ok we needed to do it anyway:

We are currently redoing all the stats and graphs for the profile page. I suspect that some of those settings may become meaningless. Pretty well every option under the grade system I think we should remove. We should also combine this page with the other profile settings page so it's all consistent. I also think some of these settings should be changeable directly in the profile page but we can sort that bit later.

So I'm going to rename this issue to be a bit more broad and tackle all of these together

@brendanheywood brendanheywood added the 5: Enhancement Build up on existing function that adds or improve functionality significantly label Feb 15, 2017
@brendanheywood brendanheywood changed the title Text wrapping can split between checkbox and text Profile page stats settings general cleanup Feb 15, 2017
@scd
Copy link
Member

scd commented Feb 20, 2017

Here is my proposed changes to each of the settings for the profile filter;

  • Profile URL: Move to general profile page

  • Show ascents of style: Remove once we have retired the old performance graph. 99% of our users are covered by sport, trad and boulder. The new graphs will cover the three styles automatically and the other components have enough in them for us not to worry.

  • Show ascents in setting (outdoor/gym). Move to general profile page. The community has very clearly spoken that it is important to distinguish. There will be a regression issue until we work out what to do with the performance graph for gym climbers. Gym routes do not have a cpr - Gym CPR #2607

  • Convert to grade system. Remove - we are doing this via contexts on profile page. Already discussed and agreed.

  • Show ascents of tick type. Remove. We are creating much better default behaviours. I think this makes no sense anymore

  • Plot period. Remove as we have good defaults and setting this at the account level could really screw with how the graphs are presented if they forget to change it.

  • Performance outliers. Remove as this is replaced by CPR logic.

  • Allow repeats. Remove as this is taken into account by CPR logic.

@scd
Copy link
Member

scd commented Mar 12, 2017

This is done.

Also uniqueAscentCount and uniqueDistanceClimbed is a permanent stat in a tooltip.

@scd scd closed this as completed Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: MUST BE RESOLVED FOR RELEASE 5: Enhancement Build up on existing function that adds or improve functionality significantly
Projects
None yet
Development

No branches or pull requests

3 participants