Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed for new 0.6.0 release #15

Closed
julienherrero opened this issue Jun 24, 2021 · 2 comments
Closed

Build failed for new 0.6.0 release #15

julienherrero opened this issue Jun 24, 2021 · 2 comments

Comments

@julienherrero
Copy link
Contributor

julienherrero commented Jun 24, 2021

Hi @theGlenn , the last release is unfortunately not working

e: /home/jitpack/build/flipperandroidnoop/src/main/java/com/facebook/flipper/plugins/databases/DatabasesFlipperPlugin.kt: (14, 5): 'onConnect' overrides nothing
e: /home/jitpack/build/flipperandroidnoop/src/main/java/com/facebook/flipper/plugins/databases/DatabasesFlipperPlugin.kt: (17, 5): 'onDisconnect' overrides nothing
e: /home/jitpack/build/flipperandroidnoop/src/main/java/com/facebook/flipper/plugins/databases/DatabasesFlipperPlugin.kt: (21, 5): 'runInBackground' overrides nothing

FAILURE: Build failed with an exception.

I think there is some mistakes with the 2 PR #13 #12. Maybe @e16din & @kobeumut can take a look?

NB: we have 2 different flipper versions declared
def flipper_version = '0.85.0'
def flipper_version = '0.87.0'
It would be great to harmonize with the same version

@theGlenn
Copy link
Owner

theGlenn commented Jul 1, 2021

Hi @julienherrero thanks reporting this, #16 should fix that issue.

@theGlenn
Copy link
Owner

theGlenn commented Jul 1, 2021

@theGlenn theGlenn closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants