Add focusOptions for sibling functions #23
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=======================================
Coverage 82.69% 82.69%
=======================================
Files 20 20
Lines 312 312
Branches 68 68
=======================================
Hits 258 258
Misses 49 49
Partials 5 5
Continue to review full report at Codecov.
|
| .DS_Store |
There was a problem hiding this comment.
please gitignore the dist back
| "name": "focus-lock", | ||
| "version": "0.8.1", | ||
| "name": "@kulevw/focus-lock", | ||
| "version": "0.8.2", |
There was a problem hiding this comment.
please do not change version manually. (as well as change the name of this package)
| /** | ||
| * options for focus call | ||
| */ | ||
| focusOptions?: FocusOptions; |
There was a problem hiding this comment.
Why I remember doing this change 😅
There was a problem hiding this comment.
The other repo - theKashey/react-focus-lock#84
| @@ -29,6 +29,10 @@ interface FocusNextOptions { | |||
| * @default true | |||
| */ | |||
| cycle?: boolean; | |||
| /** | |||
There was a problem hiding this comment.
please make this change the single change in this PR
| @@ -29,6 +29,10 @@ interface FocusNextOptions { | |||
| * @default true | |||
| */ | |||
| cycle?: boolean; | |||
| /** | |||
| * options for focus call | |||
There was a problem hiding this comment.
| * options for focus call | |
| * Optionally, can pass focus options to control the focus more precisely (ie. `{ preventScroll: true }`) |
|
Implemented in v0.9.0 |
I use focus-lock for focus management in modal dialogs, but focus-lock have helpers functions for focus management and I use sibling functions for custom select input