Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade some dependencies to remove warning when using react 17 #167

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

ianwang
Copy link
Contributor

@ianwang ianwang commented Jun 28, 2021

I'm seeing the following error the installing the current react-focus-lock

warning "react-focus-lock > react-clientside-effect@1.2.2" has incorrect peer dependency "react@^15.3.0 || ^16.0.0".
warning "react-focus-lock > use-callback-ref@1.2.1" has incorrect peer dependency "react@^16.8.0".
warning "react-focus-lock > use-sidecar@1.0.2" has incorrect peer dependency "react@^16.8.0".

after upgrading those, I think all of them support react 17 as peer dependency so the warning should go away 👍

@@ -96,8 +96,8 @@
"@babel/runtime": "^7.0.0",
"focus-lock": "^0.9.1",
"prop-types": "^15.6.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should move prop-types to peer dependency as well 🤔

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The general recommendation is to have it in deps.

@theKashey
Copy link
Owner

All tests are passed by the fact 🤷‍♂️

@theKashey theKashey merged commit a17cf97 into theKashey:master Jun 28, 2021
@theKashey
Copy link
Owner

Thank you for the contribution

@theKashey
Copy link
Owner

Released as 2.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants