Improve support for Sprint Shootout format #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdsakalu
commented
May 5, 2023
theOehrly
requested changes
May 7, 2023
|
Hi, thank you for this contribution. This is very well implemented, tested and documented already. I only have some minor notes that you should address, please. The remaining CI failure is currently expected and unrelated. You can ignore that. |
Handle cancelled quali sessions Add soft_exceptions decorator Also make session groupings variables private
|
Everything should be fixed now |
|
I'll merge this as it is. The remaining CI failures are caused by some general problems with the test runs that I'm currently fixing. So they are unrelated. Thank you very much for your work on this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprint Shootoutwhere appropriate._calculate_quali_like_session_resultsmethod to calculate quali and sprint shootout results from laps._calculate_quali_like_session_resultsto calculate sprint shootout results since Ergast doesn't support that format yet.sprint_shootoutevent format when loading the schedule. Ergast doesn't support it yet, so for now assuming any sprint race for 2023 should usesprint_shootoutformat.