-
Notifications
You must be signed in to change notification settings - Fork 2
Added sf 4.3 compatibility #6
base: master
Are you sure you want to change the base?
Conversation
Unfortunately the changes introduced in SF 4.3 are not compatible anymore. |
That was my first attempt to switch to v4.3 but not all dependencies are ready. I'll continue working on this when I finally switch so I can test everything thoroughly. |
@thePanz Please, review my changes. I refactored the code according to the difference between AmqpExt v4.2 and v4.3. Overall, looks like it is functioning, I tested it locally with a few thousands messages. I'm going to use this version in the dev environment. Also there are some considerations:
|
This (much needed) component [why isn't it included upstream?] needs this (much needed) update. |
@drzraf the changes are quite trivial, as ack/nack requires to be able to access specific messages in the queue. This is tricky as we do not have an index of messages that we can use as a db, specifically removing a message would mean to store sparse data in our I am not sure on which solution would be better here. Any inputs? |
Key/value storage is required. We might change format for
It depends on the use case. I use this plugin only for local development and ack/nack is not that critical for me. |
@karser I am planning to deprecate and remove this transport. |
That's sad. I'd say your transport better fits for local development than the alternatives you specified since it doesn't require any dependencies. |
Hi @thePanz !
The signature of TransportFactoryInterface::createTransport has changed, as of Symfony 4.3 it requires 3rd parameter: SerializerInterface.
My changes would probably break 4.2 compatibility, maybe you have better idea?