Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create QIP013 #26

Merged
merged 2 commits into from Jun 18, 2020
Merged

Create QIP013 #26

merged 2 commits into from Jun 18, 2020

Conversation

cooper7777
Copy link
Contributor

No description provided.

@jplomas jplomas merged commit 7c202cc into theQRL:master Jun 18, 2020
@0xFF0
Copy link
Contributor

0xFF0 commented Jul 4, 2021

I agree and I think this could also mitigate the risk if a malicious node sends an incorrect OTS index to trick the user to reuse an already used index.

@surg0r
Copy link
Member

surg0r commented Mar 12, 2022

This is an interesting proposal. Best and recommended practice is to use a hardware wallet to sign and track OTS consumption automatically. Least safe is to rely upon a stateless webwallet instance where current OTS state is taken live from the QRL network leaving multiple potential attack vectors from within the browser, webwallet code and a malicious connected node.

Once an XMSS OTS has been used in a transaction and stored in the chain then reuse no longer is a concern. Tricking the user into signing an unused OTS index and failing to relay that tx (or signing more than once) is a high risk vulnerability which could lead to complete loss of funds.

It does make logical sense then to store OTS index in browser storage as a sanity check and perhaps also check the chain live for agreement. The user would have to be sure to always open their wallet from the same machine to benefit from this of course.

But ultimately users should not ever be storing or entering seed phrases online to unlock wallets in routine practice in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants