/search/:username + test update #7
Conversation
| res.sendFile(path.join(__dirname + 'index.html')) | ||
| }); | ||
|
|
||
| app.get('/search/:username', function(req, res, error){ |
There was a problem hiding this comment.
You might want to update the readme to reflect this
There was a problem hiding this comment.
Does the stuff in index.html show up when you hit this route?
There was a problem hiding this comment.
Then I understand less than I thought I did
There was a problem hiding this comment.
No sorry I was mistaken. When you hit the :username route, the index.html does NOT show up. It only shows up when you hit the '/' root.
| <h1>Welcome to RuneHelper!</h1> | ||
| <p>To check your stats, change the url:</p> | ||
| <p>Example:</p> | ||
| <p>localhost:3000/INSERT_USERNAME_HERE</p> |
There was a problem hiding this comment.
This should also be updated to include search
|
It might have made things easier/ more clear if you only used one branch/PR You could have committed and pushed additional changes to the original branch instead of creating multiple PRs |
| `npm start` | ||
| `npm start` | ||
|
|
||
| ## Searching User Stats | ||
| In your browser go to localhost:3000/username where username is the |
There was a problem hiding this comment.
3000/search/username
|
Oh I see now. I was thinking that pull requests were immutable for some reason. |
|
Many lessons learned on that simple pr. I'll be sure to make a more complete pr next time. Thanks for the review! |
Added:
-added /search/:username to differentiate between a search and the default root
-reverted npm test to previous form, added /search/:username to pass tests
Working off multiple pull requests not committed to master. Wondering if there will be any problems that pop up because of that.
Realizing that I am going to have to connect this backend to a frontend to display the data how I want it. Deciding between raw html or React.js.
Going to Process JSON Data from project board before I decide.
Forgot to update the readme.