feat: use css :has() selector instead of JS detection
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the javascript that's used to detect podcast and audiobook elements with CSS, using the
:has()selector. This makes it much more reliable because it will apply to the entire page at all times, whereas I was using a hacky MutationObserver method to try and catch elements as they loaded onto the page.As a result, the
tagPodcasts()andtagAudioBooks()functions don't do anything any more, but I am leaving the original "listen to page navigation and re-apply when DOM is ready" code in place, in case I need to use it again in the future.I've also blocked some more podcast-related categories on the search page.