Now partial sorting will skip first slots instead of last #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find it much better to skip just first line of inventory instead of the last because when I pick an item from there (click) and release (Q) it's returned to the same position (if there are no gaps gaps). With previous (last line) approach it would be returned to a first empty slot which is usually outside of "unsorted" area.
Please review the changes because I'm not sure about the line "local i_slots = {i = sort_start - 1, current = sort_start, next = sort_start + 1, filters = filters}"
|
I don't personally use the part inventory sorting a whole lot, but your idea seems right. You understood the code correctly... I think at least :P It's such a mess that it took me a good while to figure out what was happening there - And I wrote it... I also changed things around a bit in an attempt to clean up the code a little and added support for player setting, so you can choose what type of sorting you want to use. I'll implement the setting along with some locale rewording tomorrow. Cheers TRK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it much better to skip sorting of a first line of inventory instead of a last because when I pick an item from there (click) and release (Q) it's returned to the same position (if there are no gaps gaps). With previous (last line) approach it would be returned to a first empty slot which is usually outside of "unsorted" area.
Please review the changes because I'm not sure about the line "local i_slots = {i = sort_start - 1, current = sort_start, next = sort_start + 1, filters = filters}"