New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[unified player] everything crashes after playing a video on fullscreen #4230
Comments
Looks like you got a crash of your codecs. That's why you can't play any video. I don't think it's related to the unified player but to your custom OS.
We have no access to mailbox you sent email to. Show the crash here |
@avently: Crash reports get imported into sentry.schabi.org (which I think you don't have access to), though there are a lot of incorrectly formatted e-mails (e.g. Gmail likes to insert line breaks and e.g. Outlook likes to add something like "Download Outlook for Android", which causes the JSON to be invalid) that won't be imported successfully. But even if it gets imported successfully, we can't know what crash report was sent by who (for privacy reasons), so we still don't know what crash report he refers to. @panacist: A logcat would also be useful. |
Ah. Interesting. Try flashing a different build of your ROM, @panacist. Maybe that particular build has a bug. @Kukulkan2019 Do you also have a custom ROM? You haven't given any details. |
@Kukulkan2019 you don't need a screenshot, you can just copy a text from crash report window and paste it here. If the app is not working, I.e. you have crashes, it's not a problem to make a crash again and to send it's text here |
This comment has been minimized.
This comment has been minimized.
@Kukulkan2019 https://user-images.githubusercontent.com/17365767/81796016-24a30b80-950d-11ea-9b0d-a263b1932f53.png See the bottom two buttons? Copy using that button, and paste the report here. |
@opusforlife2 @avently @wb9688 yeah mine is probably due to the custom ROM and how it deals with codecs, same thing happens on replicant os whenever i play a video using the mpeg4 encoding |
@opusforlife2 so now you can attach screenshots, interesting:) I mean you can select a text by long tapping on it, then press copy. Or attach screenshot from the start. |
I lifted that from the PR that implemented those two buttons. 🤭 |
@Kukulkan2019 just read it #4230 (comment) |
Did you read this? Your gmail crash reports will not help, which is why we're asking for the crash report here. I've given you a method to do it with an accompanying screenshot. Please do so. @avently There's no need to be rude. If you get annoyed by something let someone else handle it. |
Where I was rude? |
This #4230 (comment) wasn't called for. |
@avently not rude but more like impatient and thinks like everyone should be familiar with the app i mean cool it down man and everything is gonna be alright :) !! |
It looks like a comedy show. I always use custom ROMs and know that problems with codecs happens often. So you just need to find a normal rom to be sure that the problem is with NewPipe. |
@avently sure and i'll also test the app on replicant os but due to it's lack of any proprietary blobs i ain't sure enough wether the app will even function. |
When do you get this error? When you tap on "Copy formatted report" from the screenshot I posted? Or when you tap "Report error on Github"? Or when you use the Share button at the top right? |
@avently please be a bit more patient and calm. Please use "please" a bit more often. Some users might not know how things work. If you are patient and nice you will see they will be patient and nice with you to. @Kukulkan2019 this is a community development. We don't get commercial support, yet we do the best we can. Please be aware that sometimes things might not work perfectly. However you are always welcome to support us either financially or by helping us getting rid of erros. Making NewPipe work is a task that involves all of us. You are currently not helping by blaming people. Either you communicate friendly and cooperative with us or you leave this discussion. I am willing to report you if this will not work one or another way! |
If you'll notice, the "unwarranted response" was minimized as well. Can you answer these #4230 (comment) questions instead of complaining? |
I don't want to do something that I think is incorrect. You know, even if you written
Most of the people in this issue were patient and nice and you see the result. So I can say that your thought is not always correct. That's why we should be flexible instead of kind.
It's not a kind words but it's the right way to talk in the situation with this person. I think we understand each other. |
I gave you 3 options and you gave an ambiguous answer in return. If you're not going to be helpful, why are you here at all? Why even bother replying? |
@opusforlife2 @avently i've tested the app using 4 different ROMs 2 of them are stockroms and two are custom roms and here are the results : |
@panacist can you just send a crashreport? |
@avently when i said the app crashes i mean it literally crashes haha so no crash report is available ? |
@avently it even forced my phone to restart on replicant os so dunno how am i supposed to get a crash report hmmm |
That's very odd. Even if the app crashes badly enough to take you to the home screen, it opens up the Error report activity right after. |
@panacist since you are a skilled guy can you take a logcat via adb and show the crash report from there? You need to open a command line from your PC, connect a phone, type in terminal: |
@avently sure thing i just didn't know a logcat would be helpful in that case but yeah gimme a few minutes |
@avently and i will certainly be late at work so i will try to test the 6 apk when i come late at night i dunno if you will be around or not |
and once again thank you !!!!! |
Man, that's strange. I literally commened almost every piece of code that works between rotations.
That's ok. The main thing is to find what makes the freeze happening. All in 6 + No saveCurrentAndRestoreDefaultBrightness, no setup brightness, no save/restore instance state, no fragment listener Actually I'm not sure what else I can remove. If non of the apks works, just send traces. Out of ideas without them. |
What happens when he presses the back button, though? The rotation part will be the same, but the video should pause. Whether that happens or not might give more insight, no? |
No. In apks I sent the video already pauses but it doesn't help |
@avently @opusforlife2 okay good news the 7 apk didn't cause the app to crash but when rotating the screen (autorotate enabled) a black screen on the video show up for 1 to 2 seconds before it starts playing(i suspect its due to proccessing power constraints haha) . and regarding the anr i think it is unlikley to happen if i don't press the screen Continuously in a response to the app being frozen so just waiting for that to pop up is kinda absurd. |
@panacist what about 6 apk? |
@avently oops didn't test it wait a second please! |
@avently crashes the app hahah |
actually 1 and 2 apks have the same code difference as 6 vs 7. So I wonder why 1 and 2 don't work for you |
weird i will retest 2 and see again but 7 did actually play video |
@avently working!! sorry i think it was a human mistake from my side, |
@avently have you thought about the possibility that the player on the notifications is the problem try to get rid of it and see!? hahaha |
Man, please, test better next time. Two days just gone for nothing. Glad that I found the cause. Will post apk with actual fix.
It will not be like that, just for quick testing |
@avently sorry didn't mean to so what was the issue? not the codecs right? |
@avently was going to forget thank you man ! |
Of course not. If you have a working video in portrate, then nothing should stop you from viewing the same video in landscape:) |
Also you may noticed that the problem with progress indicator is fixed too |
Right now I need to update my app in Google Play, after a couple of hours I upload apk with a fix here and maybe make a PR. |
@avently yesterday i was listening to "stuck in the middle with you" while trying to fix the issue and thinking man we will never fix it, btw the chorus of the song goes something like this : |
Check this one. Is it work ok for you? P.S. comment number 100. Too much for one issue:) |
see #4272 |
Version
-latest apk provided by B0pol
Steps to reproduce the bug
Expected behavior
should be playing normally as it does for the latest newpipe version
Actual behaviour
the app crashes and after forcing it to stop i no longer can play any video on my phone even from gallery [it may be something with my phone custom rom (RR Nougat) but it never happened this is the first time].
to fix the issue i just restart the phone
The text was updated successfully, but these errors were encountered: