Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More accurate interpretations of bearing "TURN LEFT, STRAIGHT AHEAD!" #19

Closed
theSpeare opened this issue Mar 9, 2014 · 3 comments
Closed

More accurate interpretations of bearing "TURN LEFT, STRAIGHT AHEAD!" #19

theSpeare opened this issue Mar 9, 2014 · 3 comments
Labels
GUI
Milestone
Pre-release 3

Comments

@theSpeare
Copy link
Owner

This can easily be implemented through if-conditions and relative bearing comparisons. under 5 degrees should represent a "go straight ahead!" message.

Likewise remove the other necessary bearing readouts. No longer needed.
@theSpeare theSpeare added this to the Pre-release 3 milestone Mar 9, 2014
@theSpeare theSpeare added the GUI label Mar 9, 2014
@theSpeare
Copy link
Owner Author

Latest commit will implement this. A little bit too much of workaround-type-work, but it should be okay. Still requires testing because not sure if it'll break.

theSpeare added a commit that referenced this issue Mar 10, 2014
@theSpeare
Work to PR3 - ii
5ee64a9 
Issue #19 - more accurate representation of "TURN LEFT" and "TURN RIGHT"
implemented. Before heading > spotbearing means to turn left.
A problem comes up if the spot bearing is 350 and heading is 010. Which is
not heading > spotbearing.

The workaround is to shift the science bearing to 0, and apply that shift
to the rover heading. That way if the rover heading is less than 180, turn left; vice-versa.

New values for science:
1% 400-500
8% 200-400
45% 70-200
70% 30-70
else 0-30
@theSpeare
Copy link
Owner Author

650a4f3 - hopefully works now. A bit gimmicky but logically makes sense. Let's hope it works in-game. Will test tonight and then release if working.

theSpeare added a commit that referenced this issue Mar 11, 2014
@theSpeare
Finished issue #19.
492c14b 
Tested and should be doing fine. Very accurate representation of bearing directions now.
Relative bearing isn't working quite as perfectly as I'd want but that can come later. Not such a big deal.

READY FOR PRE-RELEASE 3
@theSpeare
Copy link
Owner Author

Complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
Pre-release 3
Development

No branches or pull requests
1 participant
@theSpeare