Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --style option #73

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Add --style option #73

merged 1 commit into from
Aug 4, 2020

Conversation

TedLyngmo
Copy link
Contributor

This closes #72

Signed-off-by: Ted Lyngmo ted@lyncon.se

Copy link
Owner

@theZiz theZiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the late response. Your PR looks good in general, thanks, but -f is taken already by another option, so please choose a different one. :) Totally up to you, it just needs to be free. ;)

aha.c Outdated Show resolved Hide resolved
This closes theZiz#72

Signed-off-by: Ted Lyngmo <ted@lyncon.se>
@TedLyngmo TedLyngmo changed the title Add --font-size option Add --style option Aug 4, 2020
@TedLyngmo TedLyngmo requested a review from theZiz August 4, 2020 05:25
Copy link
Owner

@theZiz theZiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes, looks good to me. But I will redesign the help a bit and I will change the short option from -o to -y as it disturbs me that there is no o in style. So just that you know you may change your scripts of you use -o instead of --style ;)

But nevertheless: Thank you very much for your input, it is very appreciated!

@TedLyngmo TedLyngmo mentioned this pull request Aug 4, 2020
@theZiz theZiz added this to the Release 0.5.1 milestone Aug 4, 2020
@theZiz theZiz merged commit f60e61d into theZiz:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

font-size option
2 participants