chore: upgrade to mypy 0.902 #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
commented
Jun 15, 2021
henryiii
commented
Jun 15, 2021
henryiii
commented
Jun 15, 2021
Uses the new pyproject.toml configuration and much tighter checking, nearly --strict
henryiii
force-pushed
the
henryiii/chore/mypy
branch
from
527b163
to
a90a90d
Compare
cjolowicz
reviewed
Jun 15, 2021
There was a problem hiding this comment.
Lovely, thank you!
I left a comment about the coverage failure in CI (we should just disable it for these lines). Also, I'd prefer to separate the switch to PEP-517 from this PR. And having some small doubts about the use of Literal.
Overall, this is great, thanks again!
This was referenced Jun 15, 2021
Merged
|
@theacodes @crwilcox |
|
Would need to rebase this on top of #457 or vice versa to handle the added dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the new
pyproject.tomlMyPy configuration and much tighter checking, nearly--strict. I only left about two strict flags turned off.