Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some conda commands not logged. #345

Closed
mforbes opened this issue Sep 8, 2020 · 3 comments · Fixed by #466
Closed

Some conda commands not logged. #345

mforbes opened this issue Sep 8, 2020 · 3 comments · Fixed by #466
Labels
bug Good first issue help wanted
Milestone
Near-term

Comments

@mforbes
Copy link

mforbes commented Sep 8, 2020

When using venv_backend="conda", the conda create command is not logged, even if -v is provided, since log=False is hard-coded in nox/virtualenv.py:

        nox.command.run(cmd, silent=True, log=False)

From the docs, I expected that running nox -v would log all commands.
@mforbes mforbes changed the title Conda commands not logged. Some conda commands not logged. Sep 8, 2020
Tolker-KU added a commit to Tolker-KU/nox that referenced this issue Dec 19, 2020
@Tolker-KU
Feat: Enable logging for creation of conda envs if verbose options is…
cd649f5 
… set. wntrblm#345
@Tolker-KU Tolker-KU mentioned this issue Dec 19, 2020
Closed
Tolker-KU added a commit to Tolker-KU/nox that referenced this issue Dec 20, 2020
@Tolker-KU
Enable logging for creation of conda envs if verbose option is set. w…
f54a2b5 
…ntrblm#345.
@theacodes theacodes added this to the Near-term milestone Mar 7, 2021
@henryiii
Copy link
Collaborator

I started to try to help with this, but ran into an incorrect type, which prompted #455. After that is fixed, then I can try to help with this.

@FollowTheProcess
Copy link
Collaborator

Hi @henryiii!

Are you still working on this?

If you're busy I wouldn't mind taking a crack at this 😃 but don't want to just take it without checking first!

@henryiii
Copy link
Collaborator

I haven't gotten back to this yet (and am unlikely to before SciPy is over). Also, I'll probably work on #448 next since I already have a PR open for that - so feel free to work on this, I'll avoid starting on it for now!

@FollowTheProcess FollowTheProcess mentioned this issue Jul 12, 2021
Merged
theacodes pushed a commit that referenced this issue Sep 9, 2021
@FollowTheProcess
Conda logs now respect nox.options.verbose. (#466)
2821216 
Fixes #345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Good first issue help wanted
Milestone
Near-term
Development

Successfully merging a pull request may close this issue.

Conda logs now respect nox.options.verbose.
Enable logging of conda env creation Tolker-KU/nox
4 participants
@theacodes @mforbes @henryiii @FollowTheProcess