Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session.warn to output warnings #482

Merged
merged 4 commits into from Sep 21, 2021

Conversation

DiddiLeija
Copy link
Collaborator

Closes #481. Create session.warn to show warnings during the session.

cc @theacodes @FollowTheProcess

Show warnings during the session.
Add a test for "session.warn"
(It is pretty similar to "test_log", but it has changed the logging level to be tested).
Run black to fix linting errors.
Remove an additional whiespace.
@DiddiLeija
Copy link
Collaborator Author

Any suggestions?

@FollowTheProcess
Copy link
Collaborator

Looks good to me 👍🏻

@FollowTheProcess FollowTheProcess merged commit 7f63350 into wntrblm:main Sep 21, 2021
@FollowTheProcess
Copy link
Collaborator

@DiddiLeija Thanks for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Expose a warn log to the session
2 participants