Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a warn log to the session #481

Closed
FollowTheProcess opened this issue Sep 21, 2021 · 6 comments · Fixed by #482
Closed

Expose a warn log to the session #481

FollowTheProcess opened this issue Sep 21, 2021 · 6 comments · Fixed by #482

Comments

@FollowTheProcess
Copy link
Collaborator

How would this feature be useful?

I often find myself using the session.log method in some of my more complex sessions to inform the user
what's going on.

I do use the session.error for failing things but occasionally I run into something that would be more suitable as a warning in the yellow text (e.g. warning if things are out of date etc.)

Describe the solution you'd like

Some way of logging a warning from within a session. This could be either a session.warn or maybe a session.log("message", type="warn") or something like that.

Describe alternatives you've considered

As far as I know there's no way of doing this currently (I could be wrong).

@DiddiLeija
Copy link
Collaborator

I'm interested on this! I like that idea. If this is going to be applied, I offer to work on it. Just tell me :)

@theacodes
Copy link
Collaborator

theacodes commented Sep 21, 2021 via email

@DiddiLeija
Copy link
Collaborator

Me too. I personally prefer session.warn instead of session.log("message", type="warn").

@FollowTheProcess
Copy link
Collaborator Author

Me too. I personally prefer session.warn instead of session.log("message", type="warn").

Yeah I agree with session.warn. Feel free to work on it if you want 👍🏻

@DiddiLeija
Copy link
Collaborator

Estupend! If no one disagrees with the idea, I will work on this.

@DiddiLeija
Copy link
Collaborator

I created #482. Review it whenever you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants