-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose a warn
log to the session
#481
Comments
I'm interested on this! I like that idea. If this is going to be applied, I offer to work on it. Just tell me :) |
I'm totally cool with session.warn
…On Tue, Sep 21, 2021 at 7:16 AM Tom Fleet ***@***.***> wrote:
*How would this feature be useful?*
I often find myself using the session.log method in some of my more
complex sessions to inform the user
what's going on.
I do use the session.error for failing things but occasionally I run into
something that would be more suitable as a warning in the yellow text (e.g.
warning if things are out of date etc.)
*Describe the solution you'd like*
Some way of logging a warning from within a session. This could be either
a session.warn or maybe a session.log("message", type="warn") or
something like that.
*Describe alternatives you've considered*
As far as I know there's no way of doing this currently (I could be wrong).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#481>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5I46YELXWV7KVSEGA3GTUDBSPRANCNFSM5EOEWXSA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Me too. I personally prefer |
Yeah I agree with |
Estupend! If no one disagrees with the idea, I will work on this. |
I created #482. Review it whenever you want. |
How would this feature be useful?
I often find myself using the
session.log
method in some of my more complex sessions to inform the userwhat's going on.
I do use the
session.error
for failing things but occasionally I run into something that would be more suitable as a warning in the yellow text (e.g. warning if things are out of date etc.)Describe the solution you'd like
Some way of logging a warning from within a session. This could be either a
session.warn
or maybe asession.log("message", type="warn")
or something like that.Describe alternatives you've considered
As far as I know there's no way of doing this currently (I could be wrong).
The text was updated successfully, but these errors were encountered: