Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW FEATURE][WORK IN PROGRESS]Implement Basics for a Web App #106

Merged
merged 25 commits into from
Dec 8, 2018

Conversation

MatejMecka
Copy link
Collaborator

Thanks for showing interest in the project and sending us a pull request.

Please prefix your pull request with [NEW FEATURE], [BUG] or [IMPROVEMENT]


What issue/feature is fixed?

#99 I am creating a Flask Handler with tests and documentation


Issue/Feature Details

You can mention the line of code that is causing the error, detail the feature you are requesting and where it can be useful.

N/A


How To Test It Locally?

cd Nephos/nephos/web
python3 webServer.py

Visit in your browser

Copy link
Owner

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @MatejMecka . I know this is a WIP but still below are some changes I would like you to implement.

  • Keep tests for web in the modular way only in the tests folder in root of the repo.
  • Write tests for all your function (almost).
  • Write docstrings in the same manner as the other modules (you're doing great on this already).
  • Use the current address of the database and do not create a new one.

I've not run it and hence some points may not be accurate.
You're doing great 👍

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   83.79%   83.79%           
=======================================
  Files          26       26           
  Lines        1413     1413           
  Branches      107      107           
=======================================
  Hits         1184     1184           
  Misses        184      184           
  Partials       45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad00acb...b94043a. Read the comment docs.

Copy link
Owner

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few things that are required to be done before I test this;

  • Add all dependencies in the Pipfile; I did not find flask_testing nor flask_sqlalchemy.
  • Update documentation regarding how to run tests. (I forgot to add this).
  • Update your importing style to be relative (as I've used everywhere).
  • Show me the screenshot of the web app running.
  • Include documentation for WebApp on the wiki (and also hint a bit in readme.md)

Pipfile Show resolved Hide resolved
Copy link
Owner

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below are some changes and improvements I want:

  • Add all dependencies to Pipfile and update it.
  • Use relative importing (as I've used everywhere) in your code as well.
  • Attach a screenshot of the web app.
  • Update documentation regarding webapp on the wiki and add some info about it in readme.md as well
  • Add instructions on how to run tests in the readme.

While doing all above tasks follow the method already used :)

@MatejMecka
Copy link
Collaborator Author

screen shot 2018-12-06 at 5 50 59 pm

screen shot 2018-12-06 at 5 50 49 pm

screen shot 2018-12-06 at 5 50 27 pm

Preview of the Web App

README.md Outdated Show resolved Hide resolved
Copy link
Owner

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement the suggested changes :)

Pipfile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Owner

@thealphadollar thealphadollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thealphadollar thealphadollar merged commit b09408c into thealphadollar:master Dec 8, 2018
@thealphadollar thealphadollar mentioned this pull request Dec 8, 2018
@MatejMecka MatejMecka deleted the feat/web branch December 8, 2018 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants