Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for thumbor-aws result storage #22

Merged
merged 1 commit into from Jan 4, 2024

Conversation

fdintino
Copy link
Member

@fdintino fdintino commented Jan 4, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Merging #22 (a6ceb01) into main (52da121) will decrease coverage by 3.04%.
The diff coverage is 82.75%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   99.87%   96.84%   -3.04%     
==========================================
  Files          16       17       +1     
  Lines         797      855      +58     
  Branches      169      176       +7     
==========================================
+ Hits          796      828      +32     
- Misses          1       22      +21     
- Partials        0        5       +5     
Files Coverage Δ
src/thumbor_video_engine/__init__.py 100.00% <100.00%> (ø)
...humbor_video_engine/result_storages/aws_storage.py 82.45% <82.45%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52da121...a6ceb01. Read the comment docs.

Copy link

github-actions bot commented Jan 4, 2024

Unit Test Results

    6 files  ± 0      6 suites  ±0   2m 42s ⏱️ -53s
  186 tests +14    186 ✅ +14   0 💤 ± 0  0 ❌ ±0 
1 102 runs  +70  1 040 ✅ + 8  62 💤 +62  0 ❌ ±0 

Results for commit 4a7a293. ± Comparison against base commit 52da121.

♻️ This comment has been updated with latest results.

@fdintino fdintino force-pushed the feat/thumbor-aws-result-storage-support branch 4 times, most recently from ec353eb to a6ceb01 Compare January 4, 2024 06:08
@fdintino fdintino force-pushed the feat/thumbor-aws-result-storage-support branch from a6ceb01 to 4a7a293 Compare January 4, 2024 16:43
@fdintino fdintino marked this pull request as ready for review January 4, 2024 16:46
@fdintino fdintino merged commit 05207ae into main Jan 4, 2024
9 checks passed
@fdintino fdintino deleted the feat/thumbor-aws-result-storage-support branch January 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants