feat: add clearUserID to AppEventsLogger (setUserId(null) throws exception from SDK)
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichan75
changed the title
mikehardy
changed the title
setUserId(null) throws exception from SDK)
mikehardy
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
wow, you added the mock entry and you targeted the beta branch so you are already working with the current typescript code, this looks fantastic. Thank you! I kicked off the CI jobs for it and assuming they pass (they should pass...) I'll generate a new beta release
mikehardy
added
pending-merge
github-actions bot
pushed a commit
that referenced
this pull request
Jan 17, 2022
## [7.0.0-beta.5](v7.0.0-beta.4...v7.0.0-beta.5) (2022-01-17) ### Features * add clearUserID to AppEventsLogger (`setUserId(null)` throws exception from SDK) ([#185](#185)) ([b3cd260](b3cd260)) ### Bug Fixes * **android, build:** delete jcenter from rootProject - should not affect consuming apps ([#184](#184)) ([dd6aaf8](dd6aaf8))
|
There was a slight release hiccup so the release bot didn't add a message to this, but it did just launch as 7.0.0-beta.5, hopefully it works for you when installed directly from npmjs.com |
mikehardy
pushed a commit
that referenced
this pull request
Jan 21, 2022
## [7.0.0-beta.5](v7.0.0-beta.4...v7.0.0-beta.5) (2022-01-17) ### Features * add clearUserID to AppEventsLogger (`setUserId(null)` throws exception from SDK) ([#185](#185)) ([b3cd260](b3cd260)) ### Bug Fixes * **android, build:** delete jcenter from rootProject - should not affect consuming apps ([#184](#184)) ([dd6aaf8](dd6aaf8))
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2022
## [7.0.0](v6.2.0...v7.0.0) (2022-01-21) ### ⚠ BREAKING CHANGES * **release:** use conventional commits style for commit parsing * update dependencies * migrate to typescript (#155) ### Features * add clearUserID to AppEventsLogger (`setUserId(null)` throws exception from SDK) ([#185](#185)) ([03306a6](03306a6)) * export all module types ([#173](#173)) ([bd7f968](bd7f968)) * **ios:** AEM logger ([#165](#165)) ([be1e861](be1e861)) ### Bug Fixes * **android, build:** delete jcenter from rootProject - should not affect consuming apps ([#184](#184)) ([a76c285](a76c285)) * **android, deprecation:** Replace deprecated GameRequestDialog ([#172](#172)) ([a0c20d2](a0c20d2)) * **android:** remove dead code ([#176](#176)) ([a24bdb4](a24bdb4)) * **iOS:** update deprecated methods ([81fc259](81fc259)) * **release:** use conventional commits style for commit parsing ([c311031](c311031)), closes [#164](#164) * update dependencies ([ddc968f](ddc968f)) ### Code Refactoring * migrate to typescript ([#155](#155)) ([d55e203](d55e203))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue occurred when called
setUserID(null)of AppEventLogger. clearing user id is required when the user signed out.I found that the
clearUserIDis missing; facebook-android-sdk, facebook-ios-sdkI added clearUserID in this PR.