New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: migrate to typescript #155
Conversation
It will be wonderful if there's a beta version on npm to test it properly, currently I am just pushing it to my repo and yarn add from there. None is it necessary, just consider it as a |
ddfc3ef
to
b69038d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self reviewed all files, issues found are all solved
A strict requirement of the migration for me is that it is buildable from source, from the installed version or from a version that is in git (so people may use a repo or branch or commit ref) then they should be able to change into the node_modules/react-native-fbsdk-next directory and run |
I've created a pre-release named |
I can try after I review it. The holidays mean I'm quite short on time though, apologies |
@mikehardy That's ok, this is no hurry. Thank you for still replying during your holidays. |
status for me:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this into a new beta branch, and semantic-release should auto-magically publish that in to a beta tag on npmjs.com
🎉 This PR is included in version 6.2.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I'm having a really frustrating time getting the version and tag lined up the way I like. The release is officially out there on the Future steps:
|
This is now successfully out as v7.0.0-beta.1 on npmjs.com and on the beta branch, got it all working. |
Thanks |
* Remove old type definitions * Migrate source to typescript * Remove use strict * Replace 'import type' with 'import' * Export all types * Unify array type syntax * Change react-native value in package.json * Add index todo * fix prettier config * prettier all files * add .vscode to .gitignore * batchCallback default value * refactor: simplify index.ts * remove types from package.json * remove "react-native": "src/index.ts" in package.json * remove unnecessary type declaration Co-authored-by: tet.bot <tet.bot@theelephant.tech> Co-authored-by: Georges DIMITRY <georges.dimitry@atlasone.io>
## [7.0.0](v6.2.0...v7.0.0) (2022-01-21) ### ⚠ BREAKING CHANGES * **release:** use conventional commits style for commit parsing * update dependencies * migrate to typescript (#155) ### Features * add clearUserID to AppEventsLogger (`setUserId(null)` throws exception from SDK) ([#185](#185)) ([03306a6](03306a6)) * export all module types ([#173](#173)) ([bd7f968](bd7f968)) * **ios:** AEM logger ([#165](#165)) ([be1e861](be1e861)) ### Bug Fixes * **android, build:** delete jcenter from rootProject - should not affect consuming apps ([#184](#184)) ([a76c285](a76c285)) * **android, deprecation:** Replace deprecated GameRequestDialog ([#172](#172)) ([a0c20d2](a0c20d2)) * **android:** remove dead code ([#176](#176)) ([a24bdb4](a24bdb4)) * **iOS:** update deprecated methods ([81fc259](81fc259)) * **release:** use conventional commits style for commit parsing ([c311031](c311031)), closes [#164](#164) * update dependencies ([ddc968f](ddc968f)) ### Code Refactoring * migrate to typescript ([#155](#155)) ([d55e203](d55e203))
continue #95
Resolve todos and fix some issues,
also changed the compiler totsc
because this is how I usually do,@react-native-community/bob
was removed.This is a huge change, before public release, I think we should have a beta version first