feat(ios): Upgrade to Facebook iOS SDK 11.2.1 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
This looks fantastic, to me, thank you very much for doing this!
After a quick scan of the changelogs it seems like doing Android to v11 might not be so bad, and to v12 on android also not so bad, but the v12 jump for iOS looks pretty big unfortunately. Any thoughts on those?
|
I've done the matching change to the android sdk and removed the same method (regarding user properties) from the entire library since it's removed there, so it's all one breaking change with one version bump - we're close to current on native SDKs now! Just iOS v12 pending |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Facebook SDK for iOS to 11.2.1.
Method
updateUserPropertiesof theRCTFBSDKAppEventsclass was removed in release 11.0.0 (changelog).Test Plan:
My app mostly logs events so I tested that it compiles, launches and events are visible in the "Test Events" tab in the Facebook Events Manager.