Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): allow null value for AppEventsLogger.setUserID #213

Merged
merged 2 commits into from Mar 4, 2022
Merged

fix(types): allow null value for AppEventsLogger.setUserID #213

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c83d0d
Allow null values for AppEventsLogger.setUserID
danilobuerger Mar 4, 2022
412f276
Update src/FBAppEventsLogger.ts
mikehardy Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FBAppEventsLogger.ts
View file
Open in desktop
Expand Up @@ -292,7 +292,7 @@ export default {
* Sets a custom user ID to associate with all app events.
* The userID is persisted until it is cleared by clearUserID method.
mikehardy marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The userID is persisted until it is cleared by clearUserID method.
* The userID is persisted unless it is cleared by calling this method again with a null userID

*/
setUserID(userID: string) {
setUserID(userID: string | null) {
AppEventsLogger.setUserID(userID);
},

Expand Down