Made a new stacking context for swipe-wrap #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added z-index: 1 to .swipe-wrap selector which creates a new stacking context. When the slider is animated, only it will be repainted. It used to be that when the slider was repainted, all the other positioned elements were repainted too.
|
This really improved the performance for me. Thanks! |
|
+1! It's really increase performance on android devices! |
|
+1 - unnecessary repaints were causing a dramatic decrease in frame rate and slight jitters on positioned elements below the slider. OSX 10.8.3, latest stable Chrome |
|
Thank you so much for finding this. Before the slider stuttered on iPad 2. Now it's buttery smooth. Sweet! |
|
+1, how a single line can change everything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added z-index: 1 to .swipe-wrap selector which creates a new stacking
context. When the slider is animated, only it will be repainted.
It used to be that when the slider was repainted, all the other
positioned elements were repainted too.
Fixes #266.