Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe 2.0 feature detection only detect transforms 3d #67

Closed
bitinn opened this issue May 12, 2012 · 2 comments
Closed

Swipe 2.0 feature detection only detect transforms 3d #67

bitinn opened this issue May 12, 2012 · 2 comments

Comments

@bitinn
Copy link

bitinn commented May 12, 2012

but in the code we see fallback support for translateX (transforms 2d), so detection should probably be using

[ 'transformProperty', 'WebkitTransform', 'MozTransform', 'OTransform', 'msTransform' ]

instead of

[ 'perspectiveProperty', 'WebkitPerspective', 'MozPerspective', 'OPerspective', 'msPerspective' ]

(list taken from modernizr.)

I am testing on latest Opera Mobile 12 on Android 2.3, and the swipe is not working as intended; changing detection makes it works again.

@bitinn
Copy link
Author

bitinn commented May 12, 2012

this also leads to the non-transform animation fallback is not consistent.

next() and prev() etc. will use slider, which fallback to _animate (change left properties), while touch event use translateX...

@thebird
Copy link
Owner

thebird commented May 19, 2012

Can you submit a pull request with the changes? :)

pads added a commit to pads/Swipe that referenced this issue Feb 13, 2013
thebird added a commit that referenced this issue Mar 3, 2013
Fix for issue #67 - use 2D transforms detection
@thebird thebird closed this as completed Mar 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants