Implement getCurrIndex function #485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a fix for Issue thebird#443. The getPos() function is meant to return the zero index of the swipe object however in the event that the swipe object has only 2 elements, the cloning functionality results in a false index value. The getCurrIndex() function is intended as a replacement that resolves this issue.
|
Hi @Petce , I maintain a independent Swipe project https://github.com/lyfeyaj/swipe (originally fork from this project) with bugfixes, features and new versions, and this bug has been fixed in https://github.com/lyfeyaj/swipe, you can take a look at it. ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a fix for Issue #443.
The
getPos()function is meant to return the zero index of the swipe object however in the event that the swipe object has only 2 elements, the cloning functionality results in a false index value.The
getCurrIndex()function is intended as a replacement that resolves this issue.