Hooks errors fix for #687

[samhatoum]

Issue by rsshilli
Tuesday Jun 05, 2018 at 18:52 GMT
Originally opened as xolvio/chimp#691

---

This fixes a few things:

• Now an error in the hook will cause the tests to fail properly
• It seems the apostrophe in the GitHub slogan has changed? I had to modify it from ASCII hex 27 to UTF-8 hex 2019 to get the tests to pass.
• I updated the text in 2 of the tests that didn't make sense and removed an index.js that looked bogus.

---

rsshilli included the following code: https://github.com/xolvio/chimp/pull/691/commits

[samhatoum]

Comment by rsshilli
Tuesday Jun 05, 2018 at 19:07 GMT

---

Huh. The tests on Firefox failed because "Error: Failed to decode response from marionette". I have no idea why that would happen (or what it means, honestly). Was that something I caused?

I'd retry the build but I don't have permission.

[samhatoum]

Comment by rsshilli
Tuesday Jun 05, 2018 at 19:09 GMT

---

These tests for Firefox passed when i ran them locally on my Ubuntu Windows Subsystem.

[samhatoum]

Comment by rsshilli
Thursday Jun 07, 2018 at 18:09 GMT

---

@samhatoum I think I need your help here. Can you give me any advice?

[rsshilli]

This fix for src/lib/cucumberjs/hooks.js is still needed:

QbDVision-Inc@b48a2a5#diff-749adcafde5c87c756c5ed23d1de29dd

In bad situations, the test will fail but the build system will think that it passed because you're not exiting with a non-zero exit code. This causes false-positive test results which is really, really bad!

[lgandecki]

@dweller23 could you please apply that change and publish a new version? Thanks!