Hooks errors fix for #687 #691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it works on Windows.
…d so it mentions node versions and OS.
…d so it mentions node versions and OS.
Fixed an apostrophe / cleaned up test cases descriptions.
|
Huh. The tests on Firefox failed because "Error: Failed to decode response from marionette". I have no idea why that would happen (or what it means, honestly). Was that something I caused? I'd retry the build but I don't have permission. |
|
These tests for Firefox passed when i ran them locally on my Ubuntu Windows Subsystem. |
|
@samhatoum I think I need your help here. Can you give me any advice? |
This was referenced Jul 21, 2018
|
Thank you for this. Chimp 1.0 has not moved to Chimpy: |
1 similar comment
|
Thank you for this. Chimp 1.0 has not moved to Chimpy: |
|
Do you mean "now" moved to Chimpy? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few things: