Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the C++ interop workaround for wchar_t #99

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Remove the C++ interop workaround for wchar_t #99

merged 3 commits into from
Oct 30, 2023

Conversation

tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Oct 10, 2023 •
edited

A new version of the Swift toolchain includes the fix for wchar_t in C++ interop, so we can remove the workaround.

@tristanlabelle
Copy link
Contributor Author

Publish workflow run: https://github.com/thebrowsercompany/swiftwinrt/actions/runs/6474675402

@tristanlabelle
Copy link
Contributor Author

It works! https://github.com/thebrowsercompany/arc/actions/runs/6483766837/job/17606263528?pr=18092

@tristanlabelle tristanlabelle changed the title Test disabling the C++ interop workaround for wchar_t Remove the C++ interop workaround for wchar_t Oct 11, 2023
@tristanlabelle tristanlabelle marked this pull request as ready for review October 11, 2023 16:35
@tristanlabelle tristanlabelle requested a review from a team as a code owner October 11, 2023 16:35
brianmichel
brianmichel approved these changes Oct 14, 2023
View reviewed changes
Copy link

@brianmichel brianmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for your service 🫡

@tristanlabelle tristanlabelle force-pushed the tristan/disable-cpp-interop-wchar_t-workaround branch from b1d7bc3 to 44135e8 Compare October 30, 2023 20:15
@tristanlabelle tristanlabelle merged commit 546b8dd into main Oct 30, 2023
1 check passed
@tristanlabelle tristanlabelle deleted the tristan/disable-cpp-interop-wchar_t-workaround branch October 30, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmichel brianmichel brianmichel approved these changes

@stevenbrix stevenbrix stevenbrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tristanlabelle @brianmichel @stevenbrix