This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
Make sure third setCookie parameter is integer #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setCookie will work even if NOW or $expiration is a string
zegenie
reviewed
Dec 4, 2016
| @@ -535,7 +535,7 @@ public function getFooterDecoration() | |||
| */ | |||
| public function setCookie($key, $value, $expiration = 864000) | |||
| { | |||
| $expiration = ($expiration !== null) ? NOW + $expiration : null; | |||
| $expiration = ($expiration !== null) ? intval(NOW + $expiration) : null; | |||
There was a problem hiding this comment.
I've seen this crop up before, and I'd like to find out where this code is being called with $expiration being a string.
There was a problem hiding this comment.
I dont think its a question of where its called (in my case runDoElevatedLogin in main\controllers\main.php), its about the environment. In my case it was:
PHP 7.0.13 and XAMPP.
"gettype (NOW)" returns string (even if its defined as "define('NOW', (integer) $starttime[1]);" in \core\framework\Context.php ), as a consequence of this "gettype ($expiration)" returns float.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setCookie will work even if NOW or $expiration is a string