Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handshake security vulnerability #21

Merged
merged 2 commits into from
Jun 9, 2017
Merged

Fix handshake security vulnerability #21

merged 2 commits into from
Jun 9, 2017

Conversation

wslaghekke
Copy link
Contributor

Fixes #8

zhil
zhil suggested changes Jun 9, 2017
View reviewed changes
Controller/HandshakeController.php Outdated
if (count($authorizationHeaderArray) > 1) {
$jwt = $authorizationHeaderArray[1];
JWT::decode($jwt, $tenant->getSharedSecret(), ['HS256']);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be

else {
   throw ... 
}

?

@thecatontheflat thecatontheflat merged commit dba00dc into thecatontheflat:master Jun 9, 2017
@thecatontheflat
Copy link
Owner

Awesome, thank you guys!

@wslaghekke wslaghekke deleted the fix_handshake_security_vuln branch June 9, 2017 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhil zhil zhil requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wslaghekke @thecatontheflat @zhil