Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate all the secrets #442

Closed
78 of 79 tasks
gerhard opened this issue Jan 14, 2023 · 6 comments
Closed
78 of 79 tasks

Rotate all the secrets #442

gerhard opened this issue Jan 14, 2023 · 6 comments
Assignees

Comments

@gerhard
Copy link
Member

gerhard commented Jan 14, 2023

We used to keep our app secrets in LastPass. While we have migrated to 1Password part of #433, in light of Hackers stole encrypted LastPass password vaults, and we’re just now hearing about it, the only way to know for sure that our secrets are secure, we must rotate all credentials that we used to store in LastPass.

We will take this opportunity to see which services are no longer in use, and DELETE them.

Used by changelog-2022-03-13 app

  • ALGOLIA_API_KEY
  • ALGOLIA_APPLICATION_ID - OK to be public, nothing secret about it
  • AWS_ACCESS_KEY_ID
  • AWS_SECRET_ACCESS_KEY
  • BACKUPS_AWS_ACCESS_KEY DELETE, no longer used
  • BACKUPS_AWS_SECRET_KEY DELETE, no longer used
  • BUFFER_TOKEN 🤷‍♀️
  • CM_API_TOKEN
  • CM_SMTP_TOKEN
  • COVERALLS_REPO_TOKEN DELETE, no longer used
  • FASTLY_API_TOKEN DELETE, no longer used
  • GITHUB_API_TOKEN
  • GITHUB_CLIENT_ID
  • GITHUB_CLIENT_SECRET
  • GRAFANA_API_KEY DELETE, no longer used
  • HCAPTCHA_SECRET_KEY DELETE, no longer used
  • HN_PASS DELETE, no longer used
  • HN_USER DELETE, no longer used
  • NOTION_API_TOKEN
  • PLUSPLUS_SLUG no need to rotate this
  • PROMETHEUS_BEARER_TOKEN_PROM_EX DELETE, no longer used
  • RECAPTCHA_SECRET_KEY DELETE, no longer used
  • SECRET_KEY_BASE
  • SENTRY_AUTH_TOKEN DELETE, no longer used
  • SHOPIFY_API_KEY
  • SHOPIFY_API_PASSWORD
  • SLACK_APP_API_TOKEN
  • SLACK_INVITE_API_TOKEN
  • TURNSTILE_SECRET_KEY
  • TWITTER_CONSUMER_KEY
  • TWITTER_CONSUMER_SECRET

ENVs in 1Password

  • ALGOLIA_API_KEY
  • ALGOLIA_APPLICATION_ID
  • AWS_ACCESS_KEY_ID
  • AWS_SECRET_ACCESS_KEY
  • BACKUPS_AWS_ACCESS_KEY DELETE, no longer used
  • BACKUPS_AWS_SECRET_KEY DELETE, no longer used
  • BUFFER_TOKEN 🤷‍♀️
  • CM_API_TOKEN
  • CM_SMTP_TOKEN
  • COVERALLS_REPO_TOKEN DELETE, no longer used
  • DNSIMPLE_ACCOUNT DELETE, no longer used
  • DNSIMPLE_TOKEN DELETE, no longer used
  • FASTLY_API_TOKEN DELETE, no longer used
  • GITHUB_API_TOKEN
  • GITHUB_CLIENT_ID
  • GITHUB_CLIENT_SECRET
  • GRAFANA_API_KEY DELETE, no longer used
  • GRAFANA_CLOUD_LOKI_PASSWORD DELETE, no longer used
  • GRAFANA_CLOUD_LOKI_USERNAME DELETE, no longer used
  • GRAFANA_CLOUD_PASSWORD DELETE, no longer used
  • GRAFANA_CLOUD_PROMEX DELETE, no longer used
  • GRAFANA_CLOUD_REMOTE_WRITE_PASSWORD DELETE, no longer used
  • GRAFANA_CLOUD_REMOTE_WRITE_USERNAME DELETE, no longer used
  • GRAFANA_CLOUD_USERNAME DELETE, no longer used
  • GRAFANA_CLOUD_lke-prod-20200426 DELETE, no longer used
  • GRAFANA_CLOUD_lke-prod-2021 DELETE, no longer used
  • HCAPTCHA_SECRET_KEY DELETE, no longer used
  • HN_PASS DELETE, no longer used
  • HN_USER DELETE, no longer used
  • HONEYCOMB_API_KEY DELETE, only needed by Fastly
  • LINODE_CLI_TOKEN DELETE, no longer used
  • METRICS_GITHUB_OAUTH_APP_CLIENT_ID DELETE, no longer used
  • METRICS_GITHUB_OAUTH_APP_CLIENT_SECRET DELETE, no longer used
  • PG_DOTCOM_PASS DELETE, no longer used
  • PLUSPLUS_SLUG
  • POSTGRES_PASSWORD DELETE, no longer used
  • PROMETHEUS_BEARER_TOKEN_PROM_EX DELETE, no longer used
  • RECAPTCHA_SECRET_KEY DELETE, no longer used
  • ROLLBAR_ACCESS_TOKEN DELETE, no longer used
  • SENTRY_AUTH_TOKEN DELETE, no longer used
  • SHOPIFY_API_KEY
  • SHOPIFY_API_PASSWORD
  • SLACK_APP_API_TOKEN
  • SLACK_DEPLOY_WEBHOOK
  • SLACK_INVITE_API_TOKEN
  • TWITTER_CONSUMER_KEY
  • TWITTER_CONSUMER_SECRET
  • UPBOUND_CLOUD_USER_TOKEN DELETE, no longer used
@gerhard gerhard self-assigned this Jan 14, 2023
@gerhard gerhard changed the title Rotate all app secrets Rotate all the secrets Jan 14, 2023
@gerhard
Copy link
Member Author

gerhard commented Feb 10, 2023

Follow-ups:

  • delete Coveralls code
  • delete HackerNews code

@jerodsanto
Copy link
Member

@gerhard pretty close to done! I believe the Sentry auth token was set up by you and I couldn't find it anywhere from my account. It's only called from the sentry-release command in the Makefile. Can you handle this one?

@gerhard
Copy link
Member Author

gerhard commented Feb 18, 2023

Yes, I set up that integration: https://changelog-media.sentry.io/settings/developer-settings/

Screenshot 2023-02-18 at 08 20 59

BUT I no longer have the necessary permissions to create a new integration.

Can you assign me Manager permissions? Knowing how I roll, I would prefer Owner so that I don't hit any limitations in the future. Only @adamstac can do this according to https://changelog-media.sentry.io/settings/members/

@jerodsanto
Copy link
Member

You are now a Manager

@gerhard
Copy link
Member Author

gerhard commented Feb 18, 2023

I have set up a new integration before realizing that I could have added a new token to the existing one. When you have a moment @adamstac, can you please delete sentry-release-on-app-start-2023-02-18 (requires Owner privileges).

Actually, you can also delete sentry-release-on-app-start. FWIW 61f1dda

@gerhard
Copy link
Member Author

gerhard commented Feb 18, 2023

I think that we can close this even though the SLACK_DEPLOY_WEBHOOK has not been rotated. It's OK to re-open if you think otherwise.

FTR: https://api.slack.com/apps/AJLKS2NAV/incoming-webhooks & #418

image

@gerhard gerhard closed this as completed Feb 18, 2023
gerhard added a commit to gerhard/changelog.com that referenced this issue Feb 18, 2023
This turned out to not be as useful in practice. When did we last track
down issues by Sentry release? Not as far as I can remember. This also
removes one more credential.

Related to thechangelog#442

Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
gerhard added a commit that referenced this issue Feb 18, 2023
This turned out to not be as useful in practice. When did we last track
down issues by Sentry release? Not as far as I can remember. This also
removes one more credential.

Related to #442

Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants