Skip to content
This repository has been archived by the owner on May 3, 2021. It is now read-only.

- add: support config for the 6 params supported by Material-UI #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kavimaluskam
Copy link

Testing file missed tho.
Fixed issue:

#17
#18

…showCheckboxes, enableSelectAll, showRowHover, stripedRow) supported by Material-UI. (Testing missed)
@kavimaluskam
Copy link
Author

And thank you so much for your work @andela-cdaniel !!!

@cvaladez
Copy link

cvaladez commented Jun 3, 2017

this addition will be great!

@cvaladez
Copy link

cvaladez commented Jun 3, 2017

might want to consider that this line in the code

<TableFooter
adjustForCheckbox={ this.props.config.showCheckboxes }

if you set this as false and you have pagination as true, the pagination does not show

@kavimaluskam
Copy link
Author

Yes. @cvaladez But as material-ui itself has similar situation, i just let it be the case.

@cvaladez
Copy link

cvaladez commented Jun 5, 2017

why not use
TableFooter
adjustForCheckbox={ this.props.config.pagination }

This will adjust the footer only when you have pagination

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants