Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag issue with Lobipanel #12

Closed
jqueryuser1 opened this issue May 28, 2016 · 9 comments
Closed

Drag issue with Lobipanel #12

jqueryuser1 opened this issue May 28, 2016 · 9 comments
Labels

Comments

@jqueryuser1
Copy link

Anyone knows a fix for the following issue? Unpin a form then move it up in your browser until the header is not visible anymore. You won't be able to pin the window or take control of the form anymore without refreshing the entire page.

@thecodeholic
Copy link
Owner

This is a bug which is going to be fixed in next updates.

@jqueryuser1
Copy link
Author

jqueryuser1 commented May 29, 2016

Thank you,

Any workaround to disable moving the form too high and loose control over it?

@thecodeholic
Copy link
Owner

For now I can not think the way how it can be fixed without updating the core of the plugin.
Thank you too

@shogunfighter
Copy link

I guess you need to limit the dragging of the lobipanel inside the html document.
This tells the jquery ui (dragging module) to limit the dragging inside the html document only..
I suggest you do this.

Open the lobipanel.js > find this.enableDrag=function(){}

this.enableDrag = function(){
me.$el.draggable({
handle: '.panel-heading',

//add the following codes
containment: "document",
scroll: false

});
return me;
};

@jqueryuser1
Copy link
Author

Thanks,

I have tested it and it seems to only work if  the panel is unpinned when there�s no scrolling on the page.

If you unpin a panel after scrolling down your page (panel located at the bottom of your page) and move it up, the issue remains.

If however you unpin a panel located at the top of the page (without scrolling down), it works.

Any idea ?

Regards

From: shogunfighter notifications@github.com
Reply-To: arboshiki/lobipanel reply@reply.github.com
Date: Tuesday 28 June 2016 at 06:19
To: arboshiki/lobipanel lobipanel@noreply.github.com
Cc: hichem agrebi hichem@agrebi.com, Author author@noreply.github.com
Subject: Re: [arboshiki/lobipanel] Drag issue with Lobipanel (#12)

I guess you need to limit the dragging of the lobipanel inside the html document.
This tells the jquery ui (dragging module) to limit the dragging inside the html document only..
I suggest you do this.

Open the lobipanel.js > find this.enableDrag=function(){}

this.enableDrag = function(){
me.$el.draggable({
handle: '.panel-heading',

//add the following codes
containment: "document",
scroll: false

});
return me;
};


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@shogunfighter
Copy link

shogunfighter commented Jun 28, 2016

@jqueryuser1

I bet you just need to customize the draggable containment parameters in such a way the lobipanel wont throw out of the window/page. Maybe you can try using a different containment parameter aside from "document". You can create your own <div> and limit the dragging of the lobipanel inside that <div>

More info:
jquery > draggable > containment

@thecodeholic
Copy link
Owner

This issue is fixed. I pushed the commit on master branch.
Please check it out, if it's fixed

thecodeholic added a commit that referenced this issue Jun 29, 2016
'parent', 'document', 'window', default 'document'.
@jqueryuser1
Copy link
Author

Good afternoon,

I was wondering whether it is possible to move the Lobipanel outside of the current page to make full use of extended or two screen monitors ?

Thanks

Regatds

Hichem

From: shogunfighter notifications@github.com
Reply-To: arboshiki/lobipanel reply@reply.github.com
Date: Tuesday 28 June 2016 at 06:19
To: arboshiki/lobipanel lobipanel@noreply.github.com
Cc: hichem agrebi hichem@agrebi.com, Author author@noreply.github.com
Subject: Re: [arboshiki/lobipanel] Drag issue with Lobipanel (#12)

I guess you need to limit the dragging of the lobipanel inside the html document.
This tells the jquery ui (dragging module) to limit the dragging inside the html document only..
I suggest you do this.

Open the lobipanel.js > find this.enableDrag=function(){}

this.enableDrag = function(){
me.$el.draggable({
handle: '.panel-heading',

//add the following codes
containment: "document",
scroll: false

});
return me;
};


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@thecodeholic
Copy link
Owner

Hello,
No this is not possible not in Lobipanel and not in any other web plugin.
Browser does not allow this to move its DOM element outside of it.

On Aug 2, 2016 10:05 PM, "jqueryuser1" notifications@github.com wrote:

Good afternoon,

I was wondering whether it is possible to move the Lobipanel outside of the
current page to make full use of extended or two screen monitors ?

Thanks

Regatds

Hichem

From: shogunfighter notifications@github.com
Reply-To: arboshiki/lobipanel reply@reply.github.com
Date: Tuesday 28 June 2016 at 06:19
To: arboshiki/lobipanel lobipanel@noreply.github.com
Cc: hichem agrebi hichem@agrebi.com, Author author@noreply.github.com
Subject: Re: [arboshiki/lobipanel] Drag issue with Lobipanel (#12)

I guess you need to limit the dragging of the lobipanel inside the html
document.
This tells the jquery ui (dragging module) to limit the dragging inside the
html document only..
I suggest you do this.

Open the lobipanel.js > find this.enableDrag=function(){}

this.enableDrag = function(){
me.$el.draggable({
handle: '.panel-heading',

//add the following codes
containment: "document",
scroll: false

});
return me;
};


You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub, or mute the thread.


You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
https://github.com/arboshiki/lobipanel/issues/12#issuecomment-236990147,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEad0nwh3OKKfsx876P3NN4WfDWiiFV2ks5qb4bqgaJpZM4IpJ_k
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants