fix primary key type after save #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhuberty
reviewed
Jan 12, 2017
| @@ -765,7 +765,10 @@ public function save(AbstractTDBMObject $object) | |||
|
|
|||
| if (!$isPkSet && count($primaryKeyColumns) == 1) { | |||
| $id = $this->connection->lastInsertId(); | |||
| $primaryKeys[$primaryKeyColumns[0]] = $id; | |||
| $pkColumn = $primaryKeyColumns[0]; | |||
| // lastInsertId returns a string but the column type is usually a int. Let's convert it back to the correct type. | |||
There was a problem hiding this comment.
Ne serait-il pas intéressant de faire une PR sur DBAL pour que lastInserId() retourne l'id dans le bon type?
There was a problem hiding this comment.
En fait, je crois qu'ils ne le font pas pour une raison de perf (de la même manière, ils ne convertissent pas automatiquement les résultats fetchés de la base de donnée et c'est à l'utilisateur de le faire à la main si il le souhaite).
Je crois que la question leur a déjà été posée et qu'ils ont dit qu'ils ne le feraient pas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.