Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing Blackfire #61

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Conversation

moufmouf
Copy link
Member

As proposed by @mnapoli in #60 , this PR installs the Blackfire extension.

That would be awesome if Blackfire was preinstalled in the Docker images. That would allow to profile PHP scripts very easily.

To make that happen the following needs to be done in the Docker images:

Users not using Blackfire should not be impacted because the extension will not do anything. (it could also be possible to make the extension opt-in through an environment variable, that would be even cleaner)

Users using Blackfire will need to:

The Blackfire extension can be enabled using the PHP_EXTENSION_XDEBUG environment variable.

If Xebug and Blackfire are enabled at the same time, a Warning will be issued on container startup.

The blackfire agent URL is customizable via the BLACKFIRE_AGENT environment variable.

The Blackfire CLI is also installed out of the box in the image.

@moufmouf moufmouf merged commit 660b206 into thecodingmachine:7.2-v1 Aug 29, 2018
@moufmouf moufmouf deleted the blackfire branch August 29, 2018 07:28
@moufmouf moufmouf mentioned this pull request Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant