Merge pull request #51 from moufmouf/autowire_alias

Fixing autowiring on service aliases
thecodingmachine · Jan 24, 2020 · df74e32 · df74e32
2 parents 33a8cbb + 0a6d3cc
commit df74e32
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/DependencyInjection/GraphqliteCompilerPass.php b/DependencyInjection/GraphqliteCompilerPass.php
@@ -304,7 +304,11 @@ private function makePublicInjectedServices(ReflectionClass $refClass, Annotatio
         });
 
         foreach ($services as $service) {
-            $container->getDefinition($service)->setPublic(true);
+            if ($container->hasAlias($service)) {
+                $container->getAlias($service)->setPublic(true);
+            } else {
+                $container->getDefinition($service)->setPublic(true);
+            }
         }
 
     }

diff --git a/Tests/Fixtures/Entities/Contact.php b/Tests/Fixtures/Entities/Contact.php
@@ -37,11 +37,12 @@ public function getName(): string
      * @Field()
      * @Autowire(for="$testService")
      * @Autowire(for="$someService", identifier="someService")
+     * @Autowire(for="$someAlias", identifier="someAlias")
      * @return string
      */
-    public function injectService(TestGraphqlController $testService = null, stdClass $someService = null): string
+    public function injectService(TestGraphqlController $testService = null, stdClass $someService = null, stdClass $someAlias = null): string
     {
-        if (!$testService instanceof TestGraphqlController || $someService === null) {
+        if (!$testService instanceof TestGraphqlController || $someService === null || $someAlias === null) {
             return 'KO';
         }
         return 'OK';

diff --git a/Tests/Fixtures/config/services.yaml b/Tests/Fixtures/config/services.yaml
@@ -20,6 +20,9 @@ services:
     someService:
         class: stdClass
 
+    someAlias:
+        alias: someService
+
     Symfony\Component\HttpFoundation\Session\Storage\Handler\NullSessionHandler:
         class: Symfony\Component\HttpFoundation\Session\Storage\Handler\NullSessionHandler
     # controllers are imported separately to make sure services can be injected