Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FactoryHydrator #64

Closed
moufmouf opened this issue May 14, 2019 · 0 comments · Fixed by #66
Closed

Remove FactoryHydrator #64

moufmouf opened this issue May 14, 2019 · 0 comments · Fixed by #66
Labels
enhancement New feature or request

Comments

@moufmouf
Copy link
Member

The HydratorInterface is useless in 4.0 since the result of a TypeMapper on input type must implement the ResolvableInputTypeInterface.

There is only one correct implementation of HydratorInterface and it is FactoryHydrator.
We should remove this abstraction.
@moufmouf moufmouf added the enhancement New feature or request label May 14, 2019
moufmouf added a commit to moufmouf/graphqlite that referenced this issue May 16, 2019
@moufmouf
Removing the concept of Hydrator
f378259 
This PR removes the `HydratorInterface` and all implementations.

When returning an input object from a TypeMapper, the object must now implement the `ResolvableMutableInputInterface` (an input object type that contains its own resolver)
The need for HydratorInterface is gone as there is only one possible correct implementation and it is now in the ArgumentResolver.

Closes thecodingmachine#64
@moufmouf moufmouf mentioned this issue May 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing the concept of Hydrator moufmouf/graphqlite
1 participant
@moufmouf