Migrating ParameterHandler to a middleware system #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the ParmeterHandlerInterface only allows for a handler to handle or not handle a parameter. There is no way a ParameterHandler can "wrap" othe parameter handlers. So there is no easy way to write a ParameterHandler that does validation upon the result of other parameter handlers. This commit moves ParameterMapperInterface to a system of ParameterMiddlewareInterface where parameter middlewares are chained. We therefore get all the benefits of middlewares when handling parameters.
|
Note: this makes thecodingmachine/graphqlite-laravel#12 possible |
…eate ParameterInterface that behaves like real input type (for Validators))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ParameterMapperInterface only allows for a handler to handle or not handle a parameter.
There is no way a ParameterMapper can "wrap" other parameter handlers. So there is no easy way to write a ParameterMapper that does validation upon the result of other parameter handlers.
This commit moves ParameterMapperInterface to a system of ParameterMiddlewareInterface where parameter middlewares are chained.
We therefore get all the benefits of middlewares when handling parameters.